On Wed, 3 Jun 2026 08:51:56 +0300
Denis Sergeev <[email protected]> wrote:
> In nfp_flower_ctrl_vnic_nfd3_xmit(), when txq is NULL, goto xmit_end
> leads to unconditional dereference of txq->qcp_q in nfp_qcp_ptr_add().
> The same goto from the "no free descriptors" path incorrectly increments
> the hardware write pointer despite no descriptor being written.
>
> Replace both gotos with early return, removing the unused xmit_end label.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Fixes: a36634e87e16 ("net/nfp: add flower ctrl VNIC Rx/Tx")
> Cc: [email protected]
>
> Signed-off-by: Denis Sergeev <[email protected]>
Applied to next-net
