> From: Thomas Monjalon [mailto:[email protected]] > Sent: Friday, 19 June 2026 09.28 > > 19/06/2026 04:03, Stephen Hemminger: > > On Wed, 17 Jun 2026 13:48:37 +0200 > > Morten Brørup <[email protected]> wrote: > > > > > > From: Huisong Li [mailto:[email protected]] > > > > Sent: Wednesday, 17 June 2026 12.28 > > > > > > > > Add the RTE_LCORE_ prefix to the lcore role enum values in > > > > rte_lcore_role_t > > > > to follow DPDK naming conventions. > > > > > > > > - ROLE_RTE -> RTE_LCORE_ROLE_RTE > > > > - ROLE_OFF -> RTE_LCORE_ROLE_OFF > > > > - ROLE_SERVICE -> RTE_LCORE_ROLE_SERVICE > > > > - ROLE_NON_EAL -> RTE_LCORE_ROLE_NON_EAL > > > > > > > > Old names are kept as macros aliasing to the new names to > preserve > > > > backward compatibility. > > > > > > > > > > Series-Acked-by: Morten Brørup <[email protected]> > > > > > > > The problem with this patch it causes build failures now with abi > diff. > > It is probably a bug of an old version of abidiff. > I recommend updating.
With the #define's the ABI has not changed. It's probably too indirect for abidiff to understand. If we absolutely want to please abidiff, we could keep the existing enums and #define RTE_LCORE_ROLE_RTE ROLE_RTE for now. But I'm in favor of what was done already.
