> -----Original Message-----
> From: Stephen Hemminger <[email protected]>
> Sent: Monday, June 22, 2026 10:53 PM
> To: Zaiyu Wang <[email protected]>; Zaiyu Wang
> <[email protected]>
> Cc: [email protected]; [email protected]
> Subject: Re: [PATCH v8 12/21] net/txgbe: fix link stability for 25G NIC
>
> On Mon, 22 Jun 2026 19:09:32 +0800
> Zaiyu Wang <[email protected]> wrote:
>
> > > > +void
> > > > +set_fields_e56(unsigned int *src_data, unsigned int bit_high,
> > > > + unsigned int bit_low, unsigned int set_value) {
> > >
> > > Function could be static here?
> >
> > Hi Stephen,
> > Thanks for your time. This function is used in both txgbe_e56.c (for
> > general PHY
> > configuration) and txgbe_e56_bp.c (for backplane mode configuration).
> > Therefore, making it static would not be feasible?
> > I have also fixed the other issues you pointed out, including the
> > spelling corrections, replacing tabs with spaces in log messages, and
> > removing the
term "master"
> from comments.
> >
> > Best regards,
> > Zaiyu
>
>
> Why I noticed was that it is a global function not following naming
> conventions.
> Either make it inline in a header or rename.
>
Thank you for the clarification.
I agree that renaming it would be a better approach.
