Replace strncpy() with safer strlcpy() which always null-terminates.

Fixes: 540a211084a7 ("bnx2x: driver core")
Cc: [email protected]

Signed-off-by: Bruce Richardson <[email protected]>
---
 drivers/net/bnx2x/bnx2x.c      | 2 +-
 drivers/net/bnx2x/bnx2x_vfpf.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/bnx2x/bnx2x.c b/drivers/net/bnx2x/bnx2x.c
index 8790c858d5..1a3956b224 100644
--- a/drivers/net/bnx2x/bnx2x.c
+++ b/drivers/net/bnx2x/bnx2x.c
@@ -3596,7 +3596,7 @@ static void bnx2x_drv_info_ether_stat(struct bnx2x_softc 
*sc)
 {
        struct eth_stats_info *ether_stat = &sc->sp->drv_info_to_mcp.ether_stat;
 
-       strncpy(ether_stat->version, BNX2X_DRIVER_VERSION,
+       strlcpy(ether_stat->version, BNX2X_DRIVER_VERSION,
                ETH_STAT_INFO_VERSION_LEN);
 
        sc->sp_objs[0].mac_obj.get_n_elements(sc, &sc->sp_objs[0].mac_obj,
diff --git a/drivers/net/bnx2x/bnx2x_vfpf.c b/drivers/net/bnx2x/bnx2x_vfpf.c
index 5411df3a38..23f576877f 100644
--- a/drivers/net/bnx2x/bnx2x_vfpf.c
+++ b/drivers/net/bnx2x/bnx2x_vfpf.c
@@ -303,7 +303,7 @@ int bnx2x_vf_get_resources(struct bnx2x_softc *sc, uint8_t 
tx_count, uint8_t rx_
 
        PMD_DRV_LOG(DEBUG, sc, "status block count = %d, base status block = 
%x",
                sc->igu_sb_cnt, sc->igu_base_sb);
-       strncpy(sc->fw_ver, sc_resp.fw_ver, sizeof(sc->fw_ver));
+       strlcpy(sc->fw_ver, sc_resp.fw_ver, sizeof(sc->fw_ver));
 
        if (rte_is_valid_assigned_ether_addr(&sc_resp.resc.current_mac_addr))
                rte_ether_addr_copy(&sc_resp.resc.current_mac_addr,
-- 
2.53.0

Reply via email to