> -----Original Message-----
> From: David Marchand <[email protected]>
> Sent: Thursday, June 25, 2026 9:39 AM
> To: Dariusz Sosnowski <[email protected]>; Bruce Richardson
> <[email protected]>
> Cc: [email protected]; Yu Jiang <[email protected]>
> Subject: Re: [PATCH v2 2/4] build: support function versioning for drivers
> 
> External email: Use caution opening links or attachments
> 
> 
> On Wed, 24 Jun 2026 at 15:15, Dariusz Sosnowski <[email protected]>
> wrote:
> >
> > Add support for enabling function versioning (through
> > use_function_versioning meson variable) for drivers, similar to
> > libraries.
> >
> > Signed-off-by: Dariusz Sosnowski <[email protected]>
> > ---
> >  drivers/meson.build | 8 ++++++++
> >  1 file changed, 8 insertions(+)
> >
> > diff --git a/drivers/meson.build b/drivers/meson.build index
> > 4d95604ecd..a63d93372a 100644
> > --- a/drivers/meson.build
> > +++ b/drivers/meson.build
> > @@ -171,6 +171,7 @@ foreach subpath:subdirs
> >          pkgconfig_extra_libs = []
> >          testpmd_sources = []
> >          require_iova_in_mbuf = true
> > +        use_function_versioning = false
> >          # for handling base code files which may need extra cflags
> >          base_sources = []
> >          base_cflags = []
> > @@ -273,6 +274,13 @@ foreach subpath:subdirs
> >          endif
> >          dpdk_conf.set(lib_name.to_upper(), 1)
> >
> > +        if developer_mode and is_windows and use_function_versioning
> > +            message('@0@: Function versioning is not supported by
> Windows.'.format(name))
> > +        endif
> > +        if use_function_versioning
> > +            cflags += '-DRTE_USE_FUNCTION_VERSIONING'
> > +        endif
> > +
> >          dpdk_extra_ldflags += pkgconfig_extra_libs
> >
> >          dpdk_headers += headers
> 
> Don't we need to build with RTE_BUILD_SHARED_LIB for the shared library
> objects?

Correct, it is needed. I'll update in v3.

Best regards,
Dariusz Sosnowski

Reply via email to