On Fri, 26 Jun 2026 06:22:04 -0400 Dawid Wesierski <[email protected]> wrote:
> Thanks again for the review, > > For v6 I have added the input validation we ccheck if the timestamp > PCAPNG_TSC_FLAG is not set on caller-provided input. > > Regarding API versioning my concern is around source-level compatibility. > Any application that calls rte_pcapng_copy() would need to be updated to > pass the additional timestamp argument right? > > Is breaking source-level compatibility for existing callers of > rte_pcapng_copy() acceptable here? DPDK does not guarantee API compatibility across releases; only ABI. As long as there is a release note this is fine. At this point, might have to wait for 26.11 release anyway. Also, this is not an API that is commonly used by applications.
