Thanks for the feedback. I will prepare a v2 for this patch. For the queue storage helpers, I will replace the macros with static inline functions, based on Stephen's suggestion. Thanks, Weijun
________________________________ From: Thomas Monjalon <[email protected]> Sent: Wednesday, June 10, 2026 9:15 AM To: Weijun Pan <[email protected]>; Hemant Agrawal <[email protected]>; Weijun Pan <[email protected]> Cc: [email protected] <[email protected]>; Sachin Saxena <[email protected]>; Jun Yang <[email protected]>; [email protected] <[email protected]>; Stephen Hemminger <[email protected]> Subject: Re: [PATCH] bus/fslmc: fix shadowed variables in queue storage macros 07/04/2026 16:09, Stephen Hemminger: > Why are these not inline functions. > Macros with lower case names are likely place fore confusion like this? Hemant, Sachin, Weijun, please could you consider this comment?
