Consolidate FM deconfiguration to avoid duplicate calls.
Move the fm_deconfig call to a single location and remove
redundant checks in the device close path.

Signed-off-by: Hemant Agrawal <[email protected]>
---
 drivers/net/dpaa/dpaa_flow.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/drivers/net/dpaa/dpaa_flow.c b/drivers/net/dpaa/dpaa_flow.c
index a10ca0cb56..1576134a39 100644
--- a/drivers/net/dpaa/dpaa_flow.c
+++ b/drivers/net/dpaa/dpaa_flow.c
@@ -725,6 +725,9 @@ int dpaa_fm_deconfig(struct dpaa_if *dpaa_intf,
 
        PMD_INIT_FUNC_TRACE();
 
+       if (!dpaa_intf->port_handle)
+               return 0;
+
        /* FM PORT Disable */
        ret = fm_port_disable(dpaa_intf->port_handle);
        if (ret != E_OK) {
@@ -784,10 +787,8 @@ int dpaa_fm_config(struct rte_eth_dev *dev, uint64_t 
req_dist_set)
        unsigned int i = 0;
        PMD_INIT_FUNC_TRACE();
 
-       if (dpaa_intf->port_handle) {
-               if (dpaa_fm_deconfig(dpaa_intf, fif))
-                       DPAA_PMD_ERR("DPAA FM deconfig failed");
-       }
+       if (dpaa_fm_deconfig(dpaa_intf, fif))
+               DPAA_PMD_ERR("DPAA FM deconfig failed");
 
        if (!dev->data->nb_rx_queues)
                return 0;
-- 
2.25.1

Reply via email to