Thanks for the review, Bruce. > Do we really need a commandline arg for this? If it's known enough to have > the extra arg passed at device init, is it not also known enough to have > the app not do dynamic reconfiguration in the first place? > > Alternatively, if the user configures packet pacing through rte_tm, can we > not at that point adjust the driver to disallow runtime config by returning > -ENOTSUP when reconfig is attempted, and no longer advertising the > capabilities? > Runtime configuration, whether with or without user interaction, should be > preferred over devargs whenever possible. > > /Bruce
Agreed. v5 drops the no_runtime_queue_setup devarg entirely. iavf_dev_info_get() now only advertises RTE_ETH_DEV_CAPA_RUNTIME_RX_QUEUE_SETUP and RTE_ETH_DEV_CAPA_RUNTIME_TX_QUEUE_SETUP while no per-queue bandwidth rte_tm hierarchy is committed; once one is committed, the capabilities are withdrawn and the ethdev layer rejects a subsequent rx/tx_queue_setup() call on a running port with -EBUSY, re-advertising automatically once the hierarchy is torn down. No application opt-in is required anymore. v5 (2 patches, replacing v4 3/5 and 4/5) is posted separately. /Dawid --------------------------------------------------------------------- Intel Technology Poland sp. z o.o. ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-316 | Kapital zakladowy 200.000 PLN. Spolka oswiadcza, ze posiada status duzego przedsiebiorcy w rozumieniu ustawy z dnia 8 marca 2013 r. o przeciwdzialaniu nadmiernym opoznieniom w transakcjach handlowych. Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiekolwiek przegladanie lub rozpowszechnianie jest zabronione. This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by others is strictly prohibited.
