Actually, please see the AI code review of this patch. Specifically, this
comment looks correct to me. What are your thoughts?

**File:** `dts/framework/testbed_model/linux_session.py`, line 228

The code checks `lshw_result.return_code != 0 and lshw_result.stdout == ""`
but the logic is incorrect. If the command fails, you should raise an
error. The `and` should likely be `or`:



Please read through the other suggestions too. There is some fluff but also
some good advice.

On Wed, Jul 8, 2026 at 8:57 PM Patrick Robb <[email protected]>
wrote:

> Please make sure you always run checkpatches, check-git-log,
> dts-check-format, and a doc build or each patch you send. I will update the
> commit message before applying. The mailmap issue will go away when your
> other series (with the mailmap addition) is applied.
>
> Thanks for the patch! Applying to next-dts.
>
> ./devtools/check-git-log.sh -n 1
> Wrong headline case:
>                         "dts: report dut and nic info during DTS run": nic
> --> NIC
> Contributor name/email mismatch with .mailmap:
>         Koushik Bhargav Nimoji <[email protected]> is unknown in
> .mailmap
>
> Invalid patch(es) found - checked 1 patch
>
> On Tue, Jul 7, 2026 at 9:46 PM Patrick Robb <[email protected]>
> wrote:
>
>> Tested-by: Patrick Robb <[email protected]>
>>
>

Reply via email to