> -----Original Message-----
> From: Stephen Hemminger <[email protected]>
> Sent: Friday, July 24, 2026 5:28 AM
> To: [email protected]
> Cc: Stephen Hemminger <[email protected]>; John Daley
> (johndale) <[email protected]>; Hyong Youb Kim (hyonkim)
> <[email protected]>
> Subject: [PATCH v2 3/9] net/enic: remove unneeded ops initialization
>
> Better to just let compiler initialize fields to NULL since then
> if fields change that driver doesn't use, the driver source
> will not need to be changed.
>
> Signed-off-by: Stephen Hemminger <[email protected]>
> ---
> drivers/net/enic/enic_ethdev.c | 11 -----------
> 1 file changed, 11 deletions(-)
>
> diff --git a/drivers/net/enic/enic_ethdev.c b/drivers/net/enic/enic_ethdev.c
> index 2e5cd186f9..648aa67a85 100644
> --- a/drivers/net/enic/enic_ethdev.c
> +++ b/drivers/net/enic/enic_ethdev.c
> @@ -1119,8 +1119,6 @@ static const struct eth_dev_ops
> enicpmd_eth_dev_ops = {
> .dev_configure = enicpmd_dev_configure,
> .dev_start = enicpmd_dev_start,
> .dev_stop = enicpmd_dev_stop,
> - .dev_set_link_up = NULL,
> - .dev_set_link_down = NULL,
> .dev_close = enicpmd_dev_close,
> .promiscuous_enable = enicpmd_dev_promiscuous_enable,
> .promiscuous_disable = enicpmd_dev_promiscuous_disable,
> @@ -1129,14 +1127,10 @@ static const struct eth_dev_ops
> enicpmd_eth_dev_ops = {
> .link_update = enicpmd_dev_link_update,
> .stats_get = enicpmd_dev_stats_get,
> .stats_reset = enicpmd_dev_stats_reset,
> - .queue_stats_mapping_set = NULL,
> .dev_infos_get = enicpmd_dev_info_get,
> .dev_supported_ptypes_get = enicpmd_dev_supported_ptypes_get,
> .mtu_set = enicpmd_mtu_set,
> - .vlan_filter_set = NULL,
> - .vlan_tpid_set = NULL,
> .vlan_offload_set = enicpmd_vlan_offload_set,
> - .vlan_strip_queue_set = NULL,
> .rx_queue_start = enicpmd_dev_rx_queue_start,
> .rx_queue_stop = enicpmd_dev_rx_queue_stop,
> .tx_queue_start = enicpmd_dev_tx_queue_start,
> @@ -1151,11 +1145,6 @@ static const struct eth_dev_ops
> enicpmd_eth_dev_ops = {
> .txq_info_get = enicpmd_dev_txq_info_get,
> .rx_burst_mode_get = enicpmd_dev_rx_burst_mode_get,
> .tx_burst_mode_get = enicpmd_dev_tx_burst_mode_get,
> - .dev_led_on = NULL,
> - .dev_led_off = NULL,
> - .flow_ctrl_get = NULL,
> - .flow_ctrl_set = NULL,
> - .priority_flow_ctrl_set = NULL,
> .mac_addr_add = enicpmd_add_mac_addr,
> .mac_addr_remove = enicpmd_remove_mac_addr,
> .mac_addr_set = enicpmd_set_mac_addr,
> --
> 2.53.0
Acked-by: Hyong Youb Kim <[email protected]>
Thanks.
-Hyong
