On Fri, 18 Oct 2024 at 18:06, David Marchand <[email protected]> wrote:
> On Fri, Oct 18, 2024 at 4:06 PM Robin Jarry <[email protected]> wrote:
> >
> > Hi everyone,
> >
> > As discussed recently [1], here is a first draft of the IPv6 APIs rework.
> > The
> > API change was announced before the 24.07 release [2]. This series is
> > intended
> > for 24.11.
> >
> > [1] http://inbox.dpdk.org/dev/[email protected]/
> > [2]
> > https://git.dpdk.org/dpdk/commit/?id=835d4c41e0ab58a115c2170c886ba6d3cc1b5764
> >
> > I tried to keep the patches as small as possible; unfortunately some of them
> > are quite big and cannot be broken down if we want to preserve a bisectable
> > tree.
> >
> > Thanks!
> >
> > Cc: Bruce Richardson <[email protected]>
> > Cc: Ferruh Yigit <[email protected]>
> > Cc: Konstantin Ananyev <[email protected]>
> > Cc: Morten Brørup <[email protected]>
> > Cc: Stephen Hemminger <[email protected]>
> > Cc: Vladimir Medvedkin <[email protected]>
> >
> > Changelog:
> >
> > v5:
> >
> > - rebase on e214d58eb87b ("net: improve VLAN header type alignment")
> > - fix include ordering
> > - improve doxygen api
> > - fix RTE_IPV6_U16_SPLIT to make sparse happy about 0xffff literals being
> > truncated
> > - reformat macros with \ only separated with a space
> > - update changelog with deprecated symbols and their replacements, if any
> >
> > Robin Jarry (17):
> > net: split raw checksum functions in separate header
> > net: split IPv4 and IPv6 symbols in separate headers
> > net: add IPv6 address structure and utils
> > net: use IPv6 structure for packet headers
> > lpm6: use IPv6 address structure and utils
> > fib6: use IPv6 address structure and utils
> > rib6: use IPv6 address structure and utils
> > cmdline: use IPv6 address structure
> > node: use IPv6 address structure and utils
> > pipeline: use IPv6 structures
> > ipsec: use IPv6 address structure
> > security: use IPv6 address structure
> > hash: use IPv6 address structure
> > gro: use IPv6 address structure
> > flow: use IPv6 address structure
> > net: add utilities for well known IPv6 address types
> > net: add function to check IPv6 version
> >
> > MAINTAINERS | 1 +
> > app/graph/ethdev.c | 44 +-
> > app/graph/ethdev.h | 9 +-
> > app/graph/ip6_route.c | 51 +-
> > app/graph/meson.build | 2 +-
> > app/graph/neigh.c | 21 +-
> > app/graph/neigh_priv.h | 4 +-
> > app/graph/route.h | 8 +-
> > app/test-fib/main.c | 74 +-
> > app/test-flow-perf/actions_gen.c | 4 +-
> > app/test-flow-perf/items_gen.c | 4 +-
> > app/test-pipeline/pipeline_hash.c | 4 +-
> > app/test-pipeline/pipeline_lpm_ipv6.c | 11 +-
> > app/test-pmd/cmdline.c | 4 +-
> > app/test-pmd/cmdline_flow.c | 14 +-
> > app/test-pmd/testpmd.h | 16 +-
> > app/test-sad/main.c | 24 +-
> > app/test/meson.build | 1 +
> > app/test/packet_burst_generator.c | 4 +-
> > app/test/test_cmdline_ipaddr.c | 49 +-
> > app/test/test_fib6.c | 92 +-
> > app/test/test_fib6_perf.c | 8 +-
> > app/test/test_ipfrag.c | 4 +-
> > app/test/test_ipsec_sad.c | 46 +-
> > app/test/test_lpm6.c | 490 +++---
> > app/test/test_lpm6_data.h | 2025 +++++++++++-----------
> > app/test/test_lpm6_perf.c | 10 +-
> > app/test/test_net_ip6.c | 195 +++
> > app/test/test_reassembly_perf.c | 23 +-
> > app/test/test_rib6.c | 55 +-
> > app/test/test_table_combined.c | 2 +-
> > app/test/test_table_tables.c | 8 +-
> > app/test/test_thash.c | 46 +-
> > doc/api/doxy-api-index.md | 4 +-
> > doc/guides/prog_guide/ipsec_lib.rst | 4 +-
> > doc/guides/rel_notes/deprecation.rst | 42 -
> > doc/guides/rel_notes/release_24_11.rst | 61 +
> > drivers/common/cnxk/cnxk_security.c | 14 +-
> > drivers/net/bnxt/bnxt_flow.c | 12 +-
> > drivers/net/bonding/rte_eth_bond_pmd.c | 6 +-
> > drivers/net/cxgbe/cxgbe_flow.c | 18 +-
> > drivers/net/dpaa2/dpaa2_flow.c | 22 +-
> > drivers/net/hinic/hinic_pmd_flow.c | 6 +-
> > drivers/net/hinic/hinic_pmd_tx.c | 2 +-
> > drivers/net/hns3/hns3_flow.c | 8 +-
> > drivers/net/i40e/i40e_flow.c | 12 +-
> > drivers/net/iavf/iavf_fdir.c | 8 +-
> > drivers/net/iavf/iavf_fsub.c | 8 +-
> > drivers/net/iavf/iavf_ipsec_crypto.c | 9 +-
> > drivers/net/ice/ice_fdir_filter.c | 12 +-
> > drivers/net/ice/ice_switch_filter.c | 16 +-
> > drivers/net/igc/igc_flow.c | 4 +-
> > drivers/net/ixgbe/ixgbe_flow.c | 12 +-
> > drivers/net/ixgbe/ixgbe_ipsec.c | 4 +-
> > drivers/net/mlx5/hws/mlx5dr_definer.c | 36 +-
> > drivers/net/mlx5/mlx5_flow.c | 6 +-
> > drivers/net/mlx5/mlx5_flow_dv.c | 16 +-
> > drivers/net/mlx5/mlx5_flow_hw.c | 10 +-
> > drivers/net/mlx5/mlx5_flow_verbs.c | 8 +-
> > drivers/net/mvpp2/mrvl_flow.c | 16 +-
> > drivers/net/nfp/flower/nfp_flower_flow.c | 34 +-
> > drivers/net/nfp/nfp_ipsec.c | 4 +-
> > drivers/net/nfp/nfp_net_flow.c | 38 +-
> > drivers/net/qede/qede_filter.c | 4 +-
> > drivers/net/sfc/sfc_flow.c | 22 +-
> > drivers/net/tap/tap_flow.c | 10 +-
> > drivers/net/txgbe/txgbe_flow.c | 12 +-
> > drivers/net/txgbe/txgbe_ipsec.c | 4 +-
> > examples/cmdline/commands.c | 30 +-
> > examples/ip_fragmentation/main.c | 23 +-
> > examples/ip_pipeline/cli.c | 61 +-
> > examples/ip_pipeline/parser.c | 2 +-
> > examples/ip_pipeline/parser.h | 3 +-
> > examples/ip_pipeline/pipeline.c | 16 +-
> > examples/ip_pipeline/pipeline.h | 6 +-
> > examples/ip_pipeline/thread.c | 15 +-
> > examples/ip_reassembly/main.c | 23 +-
> > examples/ipsec-secgw/flow.c | 45 +-
> > examples/ipsec-secgw/ipsec.c | 33 +-
> > examples/ipsec-secgw/ipsec.h | 5 +-
> > examples/ipsec-secgw/ipsec_lpm_neon.h | 7 +-
> > examples/ipsec-secgw/ipsec_worker.c | 11 +-
> > examples/ipsec-secgw/ipsec_worker.h | 4 +-
> > examples/ipsec-secgw/parser.c | 2 +-
> > examples/ipsec-secgw/parser.h | 4 +-
> > examples/ipsec-secgw/rt.c | 24 +-
> > examples/ipsec-secgw/sa.c | 37 +-
> > examples/ipsec-secgw/sad.h | 14 +-
> > examples/ipsec-secgw/sp6.c | 154 +-
> > examples/l3fwd-graph/main.c | 33 +-
> > examples/l3fwd/l3fwd_fib.c | 39 +-
> > examples/l3fwd/l3fwd_lpm.c | 8 +-
> > examples/l3fwd/l3fwd_route.h | 9 +-
> > examples/l3fwd/lpm_route_parse.c | 9 +-
> > examples/l3fwd/main.c | 32 +-
> > lib/cmdline/cmdline_parse_ipaddr.h | 3 +-
> > lib/ethdev/rte_flow.h | 22 +-
> > lib/fib/meson.build | 3 +-
> > lib/fib/rte_fib6.c | 19 +-
> > lib/fib/rte_fib6.h | 16 +-
> > lib/fib/trie.c | 117 +-
> > lib/fib/trie.h | 19 +-
> > lib/fib/trie_avx512.c | 38 +-
> > lib/fib/trie_avx512.h | 10 +-
> > lib/gro/gro_tcp6.c | 8 +-
> > lib/gro/gro_tcp6.h | 6 +-
> > lib/hash/rte_thash.h | 28 +-
> > lib/ip_frag/rte_ipv6_reassembly.c | 4 +-
> > lib/ipsec/rte_ipsec_sad.h | 5 +-
> > lib/lpm/meson.build | 1 +
> > lib/lpm/rte_lpm6.c | 148 +-
> > lib/lpm/rte_lpm6.h | 19 +-
> > lib/net/meson.build | 3 +
> > lib/net/rte_cksum.h | 180 ++
> > lib/net/rte_ip.h | 840 +--------
> > lib/net/rte_ip4.h | 381 ++++
> > lib/net/rte_ip6.h | 798 +++++++++
> > lib/node/ip6_lookup.c | 21 +-
> > lib/node/rte_node_ip6_api.h | 3 +-
> > lib/pipeline/rte_swx_ipsec.c | 10 +-
> > lib/pipeline/rte_swx_ipsec.h | 5 +-
> > lib/pipeline/rte_table_action.c | 44 +-
> > lib/pipeline/rte_table_action.h | 7 +-
> > lib/rib/meson.build | 2 +-
> > lib/rib/rte_rib6.c | 112 +-
> > lib/rib/rte_rib6.h | 27 +-
> > lib/security/rte_security.h | 5 +-
> > lib/table/rte_table_lpm_ipv6.c | 12 +-
> > lib/table/rte_table_lpm_ipv6.h | 7 +-
> > 129 files changed, 3928 insertions(+), 3501 deletions(-)
> > create mode 100644 app/test/test_net_ip6.c
> > create mode 100644 lib/net/rte_cksum.h
> > create mode 100644 lib/net/rte_ip4.h
> > create mode 100644 lib/net/rte_ip6.h
After almost two years, the next LTS release looks like a good time to
drop the deprecated stuff in the rib library.
$ git grep -i deprecated lib/rib/
lib/rib/rte_rib6.h:#define RTE_RIB6_IPV6_ADDR_SIZE
(RTE_DEPRECATED(RTE_RIB6_IPV6_ADDR_SIZE) RTE_IPV6_ADDR_SIZE)
lib/rib/rte_rib6.h: __rte_deprecated_msg("use direct struct assignment");
lib/rib/rte_rib6.h: __rte_deprecated_msg("use rte_ipv6_addr_eq");
lib/rib/rte_rib6.h:static inline uint8_t get_msk_part(uint8_t depth,
int byte) __rte_deprecated;
Could you send a patch please?
--
David Marchand
