The use of rte_memcpy() when building the RSS hash key mailbox command is control path only. Regular memcpy() has no performance disadvantage there and gets more compile time checking of the arguments.
The remaining uses of rte_memcpy() in xsc_tx_elts_store() are left alone since that is on the transmit fast path. Signed-off-by: Stephen Hemminger <[email protected]> --- drivers/net/xsc/xsc_dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/xsc/xsc_dev.c b/drivers/net/xsc/xsc_dev.c index 478f489516..baec15d153 100644 --- a/drivers/net/xsc/xsc_dev.c +++ b/drivers/net/xsc/xsc_dev.c @@ -159,7 +159,7 @@ xsc_dev_rss_key_modify(struct xsc_dev *xdev, uint8_t *rss_key, uint8_t rss_key_l in.hdr.opcode = rte_cpu_to_be_16(XSC_CMD_OP_MODIFY_NIC_HCA); key_len = RTE_MIN(rss_key_len, XSC_RSS_HASH_KEY_LEN); - rte_memcpy(in.rss.hash_key, rss_key, key_len); + memcpy(in.rss.hash_key, rss_key, key_len); rss_caps_mask |= RTE_BIT32(XSC_RSS_HASH_KEY_UPDATE); in.rss.caps_mask = rss_caps_mask; -- 2.53.0
