From: Jie Liu <[email protected]>
Several error/warning messages in sxe2_cmd_chnl.c are inaccurate or
lost context:
- vsi_info_get: message lost the vsi id; restore it
- rxq_bind_irq/rxq_unbind_irq: message lost the rxq index; restore it
- promisc_config: fix "promic" typo in the message
- queue_info_get_update/rxq_mapping_set: incorrect "get queue info
map"/"get dev caps" wording; use "rx queue mapping failed"
- txq_mapping_set: "Rx queue" should read "Tx queue"; incorrect
"get dev caps" wording should read "tx queue mapping failed"
Fixes: a2b79a93515e ("net/sxe2: support L2 filtering and MAC config")
Cc: [email protected]
Cc: [email protected]
Signed-off-by: Jie Liu <[email protected]>
---
drivers/net/sxe2/sxe2_cmd_chnl.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/net/sxe2/sxe2_cmd_chnl.c b/drivers/net/sxe2/sxe2_cmd_chnl.c
index fa73b8a8b7..9bd6e3355f 100644
--- a/drivers/net/sxe2/sxe2_cmd_chnl.c
+++ b/drivers/net/sxe2/sxe2_cmd_chnl.c
@@ -480,7 +480,7 @@ int32_t sxe2_drv_vsi_info_get(struct sxe2_adapter *adapter,
struct sxe2_vsi *vsi
&vsi_info_get_resp, sizeof(vsi_info_get_resp));
ret = sxe2_drv_cmd_exec(cdev, ¶m);
if (ret) {
- PMD_DEV_LOG_ERR(adapter, DRV, "switchdev cpvsi info get failed,
ret=%d", ret);
+ PMD_DEV_LOG_ERR(adapter, DRV, "vsi %u info get failed, ret=%d",
vsi->vsi_id, ret);
goto l_end;
}
@@ -538,7 +538,7 @@ int32_t sxe2_drv_rxq_bind_irq(struct sxe2_adapter *adapter,
uint16_t rxq_idx, ui
NULL, 0);
ret = sxe2_drv_cmd_exec(cdev, ¶m);
if (ret)
- PMD_DEV_LOG_ERR(adapter, DRV, "rxq bind irq failed, ret=%d",
ret);
+ PMD_DEV_LOG_ERR(adapter, DRV, "rxq %u bind irq failed, ret=%d",
rxq_idx, ret);
return ret;
}
@@ -558,7 +558,7 @@ int32_t sxe2_drv_rxq_unbind_irq(struct sxe2_adapter
*adapter, uint16_t rxq_idx)
NULL, 0);
ret = sxe2_drv_cmd_exec(cdev, ¶m);
if (ret)
- PMD_DEV_LOG_ERR(adapter, DRV, "rxq unbind irq failed, ret=%d",
ret);
+ PMD_DEV_LOG_ERR(adapter, DRV, "rxq %u unbind irq failed,
ret=%d", rxq_idx, ret);
return ret;
}
@@ -759,7 +759,7 @@ int32_t sxe2_drv_promisc_config(struct sxe2_adapter
*adapter, bool set)
ret = sxe2_drv_cmd_exec(cdev, ¶m);
if (ret)
- PMD_DEV_LOG_WARN(adapter, DRV, "promic config failed, ret=%d",
ret);
+ PMD_DEV_LOG_WARN(adapter, DRV, "promisc config failed, ret=%d",
ret);
return ret;
}
@@ -1684,7 +1684,7 @@ int32_t sxe2_drv_queue_info_get_update(struct
sxe2_adapter *adapter, struct eth_
&resp, sizeof(resp));
ret = sxe2_drv_cmd_exec(cdev, ¶m);
if (ret) {
- PMD_LOG_ERR(DRV, "get queue info map failed, ret=%d", ret);
+ PMD_LOG_ERR(DRV, "rx queue mapping failed, ret=%d", ret);
goto l_end;
}
@@ -1728,7 +1728,7 @@ int32_t sxe2_drv_rxq_mapping_set(struct rte_eth_dev
*eth_dev, uint16_t queue_id,
ret = sxe2_drv_cmd_exec(cdev, ¶m);
if (ret)
- PMD_LOG_ERR(DRV, "get dev caps failed, ret=%d", ret);
+ PMD_LOG_ERR(DRV, "rx queue mapping failed, ret=%d", ret);
l_end:
return ret;
@@ -1745,7 +1745,7 @@ int32_t sxe2_drv_txq_mapping_set(struct rte_eth_dev
*eth_dev, uint16_t queue_id,
txq = eth_dev->data->tx_queues[queue_id];
if (txq == NULL) {
- PMD_LOG_ERR(DRV, "Rx queue %u is not available or setup",
queue_id);
+ PMD_LOG_ERR(DRV, "Tx queue %u is not available or setup",
queue_id);
ret = -EINVAL;
goto l_end;
}
@@ -1759,7 +1759,7 @@ int32_t sxe2_drv_txq_mapping_set(struct rte_eth_dev
*eth_dev, uint16_t queue_id,
ret = sxe2_drv_cmd_exec(cdev, ¶m);
if (ret)
- PMD_LOG_ERR(DRV, "get dev caps failed, ret=%d", ret);
+ PMD_LOG_ERR(DRV, "tx queue mapping failed, ret=%d", ret);
l_end:
return ret;
--
2.52.0
