On Thu, 27 Aug 2026 11:08:07 +0200 David Marchand <[email protected]> wrote:
> On Thu, 27 Aug 2026 at 02:00, Stephen Hemminger > <[email protected]> wrote: > > > > qed_dbg_set_app_ver() validates the caller's version and stores it. > > But the variable s_app_ver is never used in DPDK driver. > > > > clang 23 reports: > > > > qede_debug.c:820:12: warning: variable 's_app_ver' set but not used > > [-Wunused-but-set-global] > > > > Remove the variable and the dead store. > > Maybe go one step further? > qed_dbg_set_app_ver() looks useless. Yes it is useless code. Looks like inherited from Linux driver.

