Currently, VFIO cleanup only unregisters multiprocess callback, but does not destroy containers, groups, and user mem maps. Do all of that on VFIO cleanup. In order to distinguish between config that is not initialized vs. config that has been initialized but happens to have fd == 0, move the global VFIO enabled flag out of the config, and add a separate per-config "enabled" flag that can be checked to avoid attempting to clean up configs that were never initialized in the first place.
While we're at it, also harden the API against repeated initialization and attempts at using the API without having VFIO initialized. Signed-off-by: Anatoly Burakov <[email protected]> --- lib/eal/freebsd/eal.c | 3 +- lib/eal/linux/eal_vfio.c | 151 +++++++++++++++++++++++++++++++++++++-- 2 files changed, 147 insertions(+), 7 deletions(-) diff --git a/lib/eal/freebsd/eal.c b/lib/eal/freebsd/eal.c index 991ca45064..aa6d4c2e16 100644 --- a/lib/eal/freebsd/eal.c +++ b/lib/eal/freebsd/eal.c @@ -846,8 +846,7 @@ int rte_vfio_enable(__rte_unused const char *modname) } RTE_EXPORT_INTERNAL_SYMBOL(rte_vfio_cleanup) -void -rte_vfio_cleanup(void) +void rte_vfio_cleanup(void) { } diff --git a/lib/eal/linux/eal_vfio.c b/lib/eal/linux/eal_vfio.c index 6c77076bc3..d4173f7a01 100644 --- a/lib/eal/linux/eal_vfio.c +++ b/lib/eal/linux/eal_vfio.c @@ -46,7 +46,7 @@ struct user_mem_maps { }; struct vfio_config { - int vfio_enabled; + bool enabled; int vfio_container_fd; int vfio_active_groups; const struct vfio_iommu_type *vfio_iommu_type; @@ -58,6 +58,9 @@ struct vfio_config { static struct vfio_config vfio_cfgs[RTE_MAX_VFIO_CONTAINERS]; static struct vfio_config *default_vfio_cfg = &vfio_cfgs[0]; +/* whether VFIO is enabled (usable) in this process */ +static bool vfio_enabled; + static int vfio_type1_dma_map(int); static int vfio_type1_dma_mem_map(int, uint64_t, uint64_t, uint64_t, int); static int vfio_spapr_dma_map(int); @@ -538,6 +541,11 @@ rte_vfio_get_group_fd(int iommu_group_num) { struct vfio_config *vfio_cfg; + if (!vfio_enabled) { + rte_errno = ENODEV; + return -1; + } + /* get the vfio_config it belongs to */ vfio_cfg = get_vfio_cfg_by_group_num(iommu_group_num); vfio_cfg = vfio_cfg ? vfio_cfg : default_vfio_cfg; @@ -686,7 +694,7 @@ vfio_sync_default_container(void) return -1; /* default container fd should have been opened in rte_vfio_enable() */ - if (!default_vfio_cfg->vfio_enabled || + if (!vfio_enabled || default_vfio_cfg->vfio_container_fd < 0) { EAL_LOG(ERR, "VFIO support is not initialized"); return -1; @@ -738,6 +746,11 @@ rte_vfio_clear_group(int vfio_group_fd) int i; struct vfio_config *vfio_cfg; + if (!vfio_enabled) { + rte_errno = ENODEV; + return -1; + } + vfio_cfg = get_vfio_cfg_by_group_fd(vfio_group_fd); if (vfio_cfg == NULL) { EAL_LOG(ERR, "Invalid VFIO group fd!"); @@ -773,6 +786,11 @@ rte_vfio_setup_device(const char *sysfs_base, const char *dev_addr, const struct internal_config *internal_conf = eal_get_internal_configuration(); + if (!vfio_enabled) { + rte_errno = ENODEV; + return -1; + } + /* get group number */ ret = rte_vfio_get_group_num(sysfs_base, dev_addr, &iommu_group_num); if (ret == 0) { @@ -1019,6 +1037,11 @@ rte_vfio_release_device(const char *sysfs_base, const char *dev_addr, int iommu_group_num; int ret; + if (!vfio_enabled) { + rte_errno = ENODEV; + return -1; + } + /* we don't want any DMA mapping messages to come while we're detaching * VFIO device, because this might be the last device and we might need * to unregister the callback. @@ -1111,7 +1134,11 @@ rte_vfio_enable(const char *modname) rte_spinlock_recursive_t lock = RTE_SPINLOCK_RECURSIVE_INITIALIZER; + if (vfio_enabled) + return 0; + for (i = 0; i < RTE_DIM(vfio_cfgs); i++) { + vfio_cfgs[i].enabled = false; vfio_cfgs[i].vfio_container_fd = -1; vfio_cfgs[i].vfio_active_groups = 0; vfio_cfgs[i].vfio_iommu_type = NULL; @@ -1167,7 +1194,8 @@ rte_vfio_enable(const char *modname) /* check if we have VFIO driver enabled */ if (default_vfio_cfg->vfio_container_fd != -1) { EAL_LOG(INFO, "VFIO support initialized"); - default_vfio_cfg->vfio_enabled = 1; + default_vfio_cfg->enabled = true; + vfio_enabled = true; } else { EAL_LOG(NOTICE, "VFIO support could not be initialized"); } @@ -1180,12 +1208,15 @@ int rte_vfio_is_enabled(const char *modname) { const int mod_available = rte_eal_check_module(modname) > 0; - return default_vfio_cfg->vfio_enabled && mod_available; + return vfio_enabled && mod_available; } int vfio_get_iommu_type(void) { + if (!vfio_enabled) + return -1; + if (default_vfio_cfg->vfio_iommu_type == NULL) return -1; @@ -1222,6 +1253,11 @@ rte_vfio_get_device_info(const char *sysfs_base, const char *dev_addr, { int ret; + if (!vfio_enabled) { + rte_errno = ENODEV; + return -1; + } + if (device_info == NULL || *vfio_dev_fd < 0) return -1; @@ -1357,7 +1393,7 @@ rte_vfio_get_container_fd(void) * The default container is set up during rte_vfio_enable(). * This function does not create a new container. */ - if (!default_vfio_cfg->vfio_enabled) + if (!vfio_enabled) return -1; return default_vfio_cfg->vfio_container_fd; @@ -1373,6 +1409,11 @@ rte_vfio_get_group_num(const char *sysfs_base, char *tok[16], *group_tok, *end; int ret; + if (!vfio_enabled) { + rte_errno = ENODEV; + return -1; + } + memset(linkname, 0, sizeof(linkname)); memset(filename, 0, sizeof(filename)); @@ -2073,6 +2114,11 @@ rte_vfio_container_create(void) { unsigned int i; + if (!vfio_enabled) { + rte_errno = ENODEV; + return -1; + } + /* Find an empty slot to store new vfio config */ for (i = 1; i < RTE_DIM(vfio_cfgs); i++) { if (vfio_cfgs[i].vfio_container_fd == -1) @@ -2090,6 +2136,7 @@ rte_vfio_container_create(void) EAL_LOG(NOTICE, "Fail to create a new VFIO container"); return -1; } + vfio_cfgs[i].enabled = true; return vfio_cfgs[i].vfio_container_fd; } @@ -2101,6 +2148,16 @@ rte_vfio_container_destroy(int container_fd) struct vfio_config *vfio_cfg; unsigned int i; + if (!vfio_enabled) { + rte_errno = ENODEV; + return -1; + } + + if (container_fd == RTE_VFIO_DEFAULT_CONTAINER_FD) { + EAL_LOG(ERR, "Cannot destroy default VFIO container"); + return -1; + } + vfio_cfg = get_vfio_cfg_by_container_fd(container_fd); if (vfio_cfg == NULL) { EAL_LOG(ERR, "Invalid VFIO container fd"); @@ -2113,6 +2170,7 @@ rte_vfio_container_destroy(int container_fd) vfio_cfg->vfio_groups[i].group_num); close(container_fd); + vfio_cfg->enabled = false; vfio_cfg->vfio_container_fd = -1; vfio_cfg->vfio_active_groups = 0; vfio_cfg->vfio_iommu_type = NULL; @@ -2126,6 +2184,11 @@ rte_vfio_container_group_bind(int container_fd, int iommu_group_num) { struct vfio_config *vfio_cfg; + if (!vfio_enabled) { + rte_errno = ENODEV; + return -1; + } + vfio_cfg = get_vfio_cfg_by_container_fd(container_fd); if (vfio_cfg == NULL) { EAL_LOG(ERR, "Invalid VFIO container fd"); @@ -2143,6 +2206,11 @@ rte_vfio_container_group_unbind(int container_fd, int iommu_group_num) struct vfio_config *vfio_cfg; unsigned int i; + if (!vfio_enabled) { + rte_errno = ENODEV; + return -1; + } + vfio_cfg = get_vfio_cfg_by_container_fd(container_fd); if (vfio_cfg == NULL) { EAL_LOG(ERR, "Invalid VFIO container fd"); @@ -2183,6 +2251,11 @@ rte_vfio_container_dma_map(int container_fd, uint64_t vaddr, uint64_t iova, { struct vfio_config *vfio_cfg; + if (!vfio_enabled) { + rte_errno = ENODEV; + return -1; + } + if (len == 0) { rte_errno = EINVAL; return -1; @@ -2204,6 +2277,11 @@ rte_vfio_container_dma_unmap(int container_fd, uint64_t vaddr, uint64_t iova, { struct vfio_config *vfio_cfg; + if (!vfio_enabled) { + rte_errno = ENODEV; + return -1; + } + if (len == 0) { rte_errno = EINVAL; return -1; @@ -2218,9 +2296,72 @@ rte_vfio_container_dma_unmap(int container_fd, uint64_t vaddr, uint64_t iova, return container_dma_unmap(vfio_cfg, vaddr, iova, len); } +static void +vfio_cleanup_config(struct vfio_config *vfio_cfg) +{ + unsigned int i; + + for (i = 0; i < RTE_DIM(vfio_cfg->vfio_groups); i++) { + struct vfio_group *group = &vfio_cfg->vfio_groups[i]; + + if (group->group_num == -1) + continue; + if (group->devices != 0) { + EAL_LOG(ERR, "Cannot cleanup VFIO group %d with %d devices", + group->group_num, group->devices); + return; + } + if (group->fd >= 0 && close(group->fd) < 0) { + EAL_LOG(ERR, "Cannot close VFIO group %d: %s", + group->group_num, strerror(errno)); + return; + } + + group->group_num = -1; + group->fd = -1; + group->devices = 0; + vfio_cfg->vfio_active_groups--; + } + + /* if there are still active groups, we cannot cleanup the container */ + if (vfio_cfg->vfio_active_groups != 0) { + EAL_LOG(ERR, "Cannot cleanup VFIO container with %d active groups", + vfio_cfg->vfio_active_groups); + return; + } + + if (vfio_cfg->vfio_container_fd >= 0 && + close(vfio_cfg->vfio_container_fd) < 0) { + EAL_LOG(ERR, "Cannot close VFIO container: %s", strerror(errno)); + return; + } + + vfio_cfg->vfio_container_fd = -1; + vfio_cfg->enabled = false; + vfio_cfg->vfio_iommu_type = NULL; + + vfio_cfg->mem_maps.n_maps = 0; + memset(vfio_cfg->mem_maps.maps, 0, sizeof(vfio_cfg->mem_maps.maps)); +} + RTE_EXPORT_INTERNAL_SYMBOL(rte_vfio_cleanup) void rte_vfio_cleanup(void) { + unsigned int i; + + if (!vfio_enabled) + return; + vfio_mp_sync_cleanup(); + + /* mem events can only be unregistered from the primary process */ + if (rte_eal_process_type() == RTE_PROC_PRIMARY) + rte_mem_event_callback_unregister(VFIO_MEM_EVENT_CLB_NAME, NULL); + + /* cleanup all enabled configs, ignore failures */ + for (i = 0; i < RTE_DIM(vfio_cfgs); i++) { + if (vfio_cfgs[i].enabled) + vfio_cleanup_config(&vfio_cfgs[i]); + } } -- 2.52.0
