On Wed, Sep 02, 2026 at 11:09:02AM +0200, David Marchand wrote:
> On Wed, 2 Sept 2026 at 10:25, <[email protected]> wrote:
> >
> > From: Jerin Jacob <[email protected]>
> >
> > The ptp_tap_relay_sw example was not building because
> > examples/meson.build was not updated to wire up this directory.
> 
> Ouch, the whole example looks like dead code.
> I wonder how it was tested by the author...
> The series that introduced it has no trace of touching
> examples/meson.build in the v6, v7 and v8 iterations :-(.
> 
> 
> >
> > Fixes: bec00deaa8fb ("examples/ptp_tap_relay_sw: add PTP transparent clock 
> > relay")
> > Cc: [email protected]
> >
> > Signed-off-by: Jerin Jacob <[email protected]>
> 
> The fix lgtm.
> For the record, it is the only dead example at this point in time in DPDK.
> 
It's not dead code, since it was buildable before when it was named using
"examples=" parameter. The list of all examples is only used when
"-Dexamples=all" is passed, so we are just missing this examples from
automated build testing using the "all" param.

Reply via email to