MAC addresses removal was tied with VMDq pools even when not used.
So if VMDq is not enabled, no address would be ever removed.
Fixes: 9de506a6c781 ("ethdev: skip VMDq pools unless configured")
Signed-off-by: David Marchand <[email protected]>
---
I could not test the change as my setups are KO atm.
Probably worth squashing in 9de506a6c781 before pulling to main
Changes since v1:
- fixed compilation,
---
drivers/net/intel/i40e/i40e_ethdev.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/net/intel/i40e/i40e_ethdev.c
b/drivers/net/intel/i40e/i40e_ethdev.c
index b6b2d291ee..3c01354c39 100644
--- a/drivers/net/intel/i40e/i40e_ethdev.c
+++ b/drivers/net/intel/i40e/i40e_ethdev.c
@@ -4509,11 +4509,16 @@ i40e_macaddr_remove(struct rte_eth_dev *dev, uint32_t
index)
struct rte_ether_addr *macaddr;
int ret;
uint32_t i;
+ bool vmdq;
uint64_t pool_sel;
macaddr = &(data->mac_addrs[index]);
- pool_sel = dev->data->mac_pool_sel[index];
+ vmdq = (dev->data->dev_conf.rxmode.mq_mode & RTE_ETH_MQ_RX_VMDQ_FLAG)
!= 0;
+ if (!vmdq)
+ pool_sel = 1;
+ else
+ pool_sel = dev->data->mac_pool_sel[index];
for (i = 0; i < sizeof(pool_sel) * CHAR_BIT; i++) {
if (pool_sel & RTE_BIT64(i)) {
--
2.54.0
