On Fri, 11 Sept 2026 at 17:37, David Marchand <[email protected]> wrote:
> Interesting..
>
> It's been so long I started touching this code, I am not sure at what
> I tested now...
>
> It seems I found a leak of the mac address array on VF reset.
> iavf_dev_uninit + iavf_dev_init results in overwriting
> dev->data->mac_addrs right?
>
> This should break the mac restoration during a VF reset, regardless of
> who does it, the driver or ethdev.
>
> The multicast addresses look unaffected, as those are stored in the
> iavf_info struct.
>
> I could copy the mac address and reinsert the mac addresses during
> iavf_post_reset_reconfig...
> But I think it is simpler to just check eth->data->mac_addrs state in
> iavf_dev_init.

I think I'll just embed this array in iavf_info, which already has the
multicast mac addresses.
That will just work.

I just need to carefully sanitize dev->data->mac_addrs before
releasing the port.


-- 
David Marchand

Reply via email to