On Mon, Sep 14, 2026 at 01:03:50PM +0300, Artem Novikov wrote:
> Non-leaf node validation rejects any non-NULL WFQ weight mode before
> checking the SP priority count. Therefore the later else-if branch
> cannot be reached, because wfq_weight_mode is guaranteed to be NULL at
> that point.
>
> Remove the dead branch to avoid keeping an impossible validation path in
> the DCF scheduler parameter checks.
>
> Fixes: 3a6bfc37eaf4 ("net/ice: support QoS config VF bandwidth in DCF")
> Cc: [email protected]
> Cc: [email protected]
>
> Signed-off-by: Artem Novikov <[email protected]>
> ---
Acked-by: Bruce Richardson <[email protected]>
> drivers/net/intel/ice/ice_dcf_sched.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/net/intel/ice/ice_dcf_sched.c
> b/drivers/net/intel/ice/ice_dcf_sched.c
> index 795b6e683d..5895407331 100644
> --- a/drivers/net/intel/ice/ice_dcf_sched.c
> +++ b/drivers/net/intel/ice/ice_dcf_sched.c
> @@ -188,12 +188,6 @@ ice_dcf_node_param_check(struct ice_dcf_hw *hw, uint32_t
> node_id,
> RTE_TM_ERROR_TYPE_NODE_PARAMS_N_SP_PRIORITIES;
> error->message = "SP priority not supported";
> return -EINVAL;
> - } else if (params->nonleaf.wfq_weight_mode &&
> - !(*params->nonleaf.wfq_weight_mode)) {
> - error->type =
> - RTE_TM_ERROR_TYPE_NODE_PARAMS_WFQ_WEIGHT_MODE;
> - error->message = "WFP should be byte mode";
> - return -EINVAL;
> }
>
> return 0;
> --
> 2.43.0
>
