one nit below, apart from it,
Acked-by: Vladimir Medvedkin <[email protected]>

On 9/16/2026 1:18 PM, Anatoly Burakov wrote:
Use the new flow graph API and the common parsing framework to implement
flow parser for L2 tunnel.

There are two L2-tag-related features in the driver: the global per-port
one, and the one that can direct traffic to specific queues (the one the
engine targets). The former is left completely untouched, while the latter
one is migrated to use engine infrastructure and use internal tracking.

Signed-off-by: Anatoly Burakov<[email protected]>
---
  drivers/net/intel/ixgbe/ixgbe_ethdev.c     | 248 +---------------
  drivers/net/intel/ixgbe/ixgbe_ethdev.h     |  26 +-
  drivers/net/intel/ixgbe/ixgbe_flow.c       | 206 +------------
  drivers/net/intel/ixgbe/ixgbe_flow.h       |   1 +
  drivers/net/intel/ixgbe/ixgbe_flow_l2tun.c | 317 +++++++++++++++++++++
  drivers/net/intel/ixgbe/meson.build        |   1 +
  6 files changed, 326 insertions(+), 473 deletions(-)
  create mode 100644 drivers/net/intel/ixgbe/ixgbe_flow_l2tun.c

diff --git a/drivers/net/intel/ixgbe/ixgbe_ethdev.c 
b/drivers/net/intel/ixgbe/ixgbe_ethdev.c
index 00ba6f32fa9..3923a00c284 100644
--- a/drivers/net/intel/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/intel/ixgbe/ixgbe_ethdev.c
@@ -149,7 +149,6 @@ static int eth_ixgbe_dev_uninit(struct rte_eth_dev 
*eth_dev);
  static int ixgbe_fdir_filter_init(struct rte_eth_dev *eth_dev);
  static int ixgbe_fdir_filter_uninit(struct rte_eth_dev *eth_dev);
  static int ixgbe_l2_tn_filter_init(struct rte_eth_dev *eth_dev);
-static int ixgbe_l2_tn_filter_uninit(struct rte_eth_dev *eth_dev);
  static int ixgbe_ntuple_filter_uninit(struct rte_eth_dev *eth_dev);
  static int ixgbe_dev_configure(struct rte_eth_dev *dev);
  static int ixgbe_dev_start(struct rte_eth_dev *dev);
@@ -1392,7 +1391,6 @@ eth_ixgbe_dev_init(struct rte_eth_dev *eth_dev, void 
*init_params __rte_unused)
        return 0;
err_flow_engine_conf_init:
-       ixgbe_l2_tn_filter_uninit(eth_dev);
remove "err_flow_engine_conf_init:" label too?
  err_l2_tn_filter_init:
        ixgbe_fdir_filter_uninit(eth_dev);
  err_fdir_filter_init:
@@ -1462,25 +1460,6 @@ static int ixgbe_fdir_filter_uninit(struct rte_eth_dev 
*eth_dev)
        return 0;
  }
<snip>

--
Regards,
Vladimir

Reply via email to