Re: [PATCH v3 04/16] net/ice: use common division round up macro

[Bruce Richardson]

On Tue, Sep 22, 2026 at 06:07:27PM -0700, Joshua Washington wrote:
> The RTE_DIV_ROUND_UP in rte_common.h makes DIV_ROUND_UP redundant.
> 
> Signed-off-by: Joshua Washington <joshw...@google.com>
> Reviewed-by: Stephen Hemminger <step...@networkplumber.org>
> ---
Acked-by: Bruce Richardson <bruce.richard...@intel.com>
>  drivers/net/intel/ice/base/ice_osdep.h | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/net/intel/ice/base/ice_osdep.h 
> b/drivers/net/intel/ice/base/ice_osdep.h
> index 5d92cf5aa4..3ef52eae6d 100644
> --- a/drivers/net/intel/ice/base/ice_osdep.h
> +++ b/drivers/net/intel/ice/base/ice_osdep.h
> @@ -311,13 +311,12 @@ ice_hweight32(u32 num)
>       return bits;
>  }
>  
> -#define DIV_ROUND_UP(n, d) (((n) + (d) - 1) / (d))
>  #define DELAY(x) rte_delay_us(x)
>  #define ice_usec_delay(x, y) rte_delay_us(x)
>  #define ice_msec_delay(x, y) rte_delay_us(1000 * (x))
>  #define udelay(x) DELAY(x)
>  #define msleep(x) DELAY(1000 * (x))
> -#define usleep_range(min, max) msleep(DIV_ROUND_UP(min, 1000))
> +#define usleep_range(min, max) msleep(RTE_DIV_ROUND_UP(min, 1000))
>  
>  struct ice_list_entry {
>       LIST_ENTRY(ice_list_entry) next;
> -- 
> 2.55.0.1082.g2b9226bbc0-goog
>