On 9/24/2026 7:51 PM, Omar Munchaev wrote:
its look like, that some parts of fdir code was not updated with new
generic ci_rx_flex_desc. This patch fixes it
Also im found out more verbose logs for ice_check_fdir_programming_status
in linux driver implementation in function ice_vf_verify_rx_desc:
https://github.com/intel/ethernet-linux-ice/blob/e4a92b1e84e084bc599580d065020986e501b8ad/src/ice_virtchnl_fdir.c#L3513
Signed-off-by: Omar Munchaev <[email protected]>
---
Hi Omar,
This looks like two commits jammed together into one. I would split up
the ci_rx_flex_desc changes from the rest of the fix (the logging
changes are technically separate but IMO they can go in with the macro
changes). The flex desc changes in particular would probably also
require a Fixes: tag and a Cc: stable if the source commit is old enough
to be in stable releases.
For the macro changes, DPDK is a BSD-3 clause licensed project, so
technically we cannot use kernel code as it's GPL-licensed. Please do
not refer to kernel implementation directly.
I do however think it's worth rewriting the Rx status etc code with
FIELD_GET macros the way you did as that makes the code a lot clearer,
and better detailed logging is certainly appreciated.
This patch would also benefit from better commit message. Suggested
rewording:
[patch 1: flex descriptor changes]
net/ice: fix missing type casts for flex descriptors
When ice driver was ported to use the common Rx descriptor format, some
type casts were missed. Add them.
Fixes: <sha of commit that introduced the issue>
Cc: [email protected] [possibly - double check if this is needed]
---
[patch 2: macro/logging changes]
net/ice: use macros to get field values
Currently, in ice_check_fdir_programming_status, descriptor fields are
accessed through direct bit mask manipulation and shifts. The ice driver
has macros for this, so rewrite the function to use FIELD_GET macros
instead.
--
Thanks,
Anatoly
