On Fri, Sep 25, 2026 at 03:33:08PM +0100, Loftus, Ciara wrote:
> > Subject: Re: [PATCH] net/iavf: fix dead store on reset path
> >
> > On 9/25/2026 10:58 AM, Ciara Loftus wrote:
> > > When dev_start fails during reset recovery, the code defers the start
> > > to the next link-up event and resets ret to 0 to avoid treating this
> > > as an error. This is redundant since ret is unconditionally
> > > overwritten by the return value of iavf_post_reset_reconfig()
> > > immediately after. Remove the dead assignment.
> > >
> > > Fixes: 9aac2219dc2a ("net/iavf: defer device start when PF VSI not ready")
> > >
> > > Signed-off-by: Ciara Loftus <[email protected]>
> > > ---
> >
> > I wouldn't really qualify this as a bug fix except maybe static analysis
> > tools might flag it so perhaps having a Fixes tag is worth it.
>
> Apologies this was indeed found by static analysis and should have
> included the following tag, if it can be added on apply:
>
> Coverity issue: 506150
>
> >
> > Acked-by: Anatoly Burakov <[email protected]>
> >
Added the coverity issue tag - because otherwise I was wondering why we
were bothering with this - and applied patch to dpdk-next-net-intel
Thanks,
/Bruce
