On Fri, 2 Oct 2026 at 11:46, Thomas Monjalon <[email protected]> wrote: > > 01/10/2026 11:05, David Marchand: > > --- a/devtools/linux-uapi.sh > > +++ b/devtools/linux-uapi.sh > > @@ -13,6 +13,9 @@ file="" > > check_headers=false > > quiet=false > > > > +# Require unifdef > > +unifdef -h >/dev/null 2>&1 || { echo "This script requires unifdef."; exit > > 1; } > > Do you need to send the message to stderr?
Yes. > > --- a/drivers/net/nbl/nbl_common/nbl_userdev.c > > +++ b/drivers/net/nbl/nbl_common/nbl_userdev.c > > @@ -2,8 +2,9 @@ > > * Copyright 2025 Nebulamatrix Technology Co., Ltd. > > */ > > > > -#include "nbl_userdev.h" > > #include <uapi/linux/vfio.h> > > + > > +#include "nbl_userdev.h" > > #include <rte_vfio.h> > > This is tricky. > Is it documented that uAPI headers should be included first? https://doc.dpdk.org/guides/contributing/linux_uapi.html#header-inclusion-into-library-or-driver """ This inclusion must be done before any header external to DPDK is included, to prevent inclusion of the system uAPI header in any of those external headers. """ -- David Marchand
