This series collects a set of fixes and enhancements for the NXP DPAA
bus, mempool, dma, crypto and net drivers targeting 26.11.
It includes memory-leak and resource-cleanup fixes on the device
remove/close paths, more robust frame queue and congestion-group
shutdown, secondary-process safety guards, BPID and cgrid lifecycle
handling, and several new features: offline (O/H) port device support,
enhanced virtual storage profile (VSP) port support, fmcless Rx queue
configuration via devargs, Rx/Tx taildrop threshold devargs, non
fmX-macY shared Ethernet naming, and DMA scatter-gather and
errata-workaround devargs. Documentation and release notes are updated
accordingly.
v23:
* crypto/dpaa_sec: release the FQIDs as contiguous runs again. v22
released them one at a time, which cost one ioctl per queue, up to
4096 for inq[], undoing the batching this patch adds. Runs of
adjacent FQIDs that shut down cleanly are now freed with a single
qman_release_fqid_range(), and a queue that fails to shut down
still keeps its FQID reserved.
* net/dpaa: correct the NULL deref trigger in the remove fix commit
message. dpaa_bus_cleanup() only calls remove for probed devices,
so the case is an application that closed its ports before
rte_eal_cleanup().
* drivers: correct the reason the cgrid cleanup patch fails the probe
on a qman_create_cgr() error. A CGR whose creation failed is never
linked into the portal list; the hazard is the error path this
patch adds, which deletes one CGR per initialised queue.
* net/dpaa: commit messages for the taildrop and fmcless rxq devargs
now match the code. Both reject a malformed value instead of using
the default, and the taildrop range check covers negatives as well
as values above UINT16_MAX.
v22:
* drivers: in the offline port close path, release an FQID only
after qman_shutdown_fq() has succeeded. It returns -EBUSY when the
retire does not complete, including for a queue towards a DCP
channel with frames still pending, which is where the Tx FQ points.
* crypto/dpaa_sec: same fix in dpaa_sec_uninit(), releasing only the
FQIDs whose queues shut down.
* drivers: save errno before logging it in the six offline port
ask_ctrl ioctl error paths.
* net/dpaa: correct the Fixes tag on the FMC init fix; the referred
commit is f5fe3eed5122, not f5fe3eed51d2.
* drivers: drop the now-unused DPAA_1G_MAC_START_IDX,
DPAA_2_5G_MAC_START_IDX, HI16_OF_U48() and LO32_OF_U48(), and the
dead num_rx_fqs store on the FMC init error path.
* mempool/dpaa: pass the destructor priority as a literal to
RTE_FINI_PRIO(); the macro token pastes its argument onto
RTE_PRIORITY_, so the numeric macro has to stay.
* doc: record that the default FMCLESS Rx queue count changed from
the lcore count to the per-port maximum.
v21:
* net/dpaa: jump to free_tx on the tx_conf_queues, cgr_tx and Tx
CGRID-range failures in dpaa_dev_init(); free_rx releases neither
tx_queues nor tx_conf_queues, so those two arrays leaked.
* net/dpaa: range-check the drv_rx_taildrop, drv_tx_taildrop and
drv_fmcless_rxq devarg values before narrowing them, and stop
treating a parse error as an absent key.
* drivers: release the Rx and Tx FQIDs in the offline port close
path; both queues are created with QMAN_FQ_FLAG_DYNAMIC_FQID.
* Commit messages: removed statements describing changes that were
not in the corresponding diff.
v20:
* net/dpaa: propagate the dpaa_port_fmc_init() error instead of
returning success with no Rx queues, as a separate fix with a
Fixes tag so it can be backported.
* drivers: drop the unused rte_dpaa_bus_oldev_enabled() and add
rte_pmd_dpaa_oldev.h to doc/api/doxy-api-index.md.
* drivers: use qman_pending_fq_by_cgrid_range() over the whole Rx
and Tx CGRID range, so a port close costs two FQID space scans
rather than one per congestion group.
* doc: name the new experimental offline port functions in the
release notes, document that drv_oldev switches the bus to
allowlist mode, and log an over-long drv_sh_if_name.
v19:
addressed AI review comments
Still open, to be fixed in a follow-up series rather than here:
qman_create_fq() also takes an FQ lookup table entry on 64-bit, and
only qman_destroy_fq() clears it. Releasing it needs the FQ marked
out of service after shutdown (qman_shutdown_fq() leaves fq->state
untouched) and a new exported bus/dpaa helper, so it is grouped with
the pre-existing FMCLESS Rx FQID leak in net/dpaa.
Gagandeep Singh (2):
dma/dpaa: add devargs for SG and errata workaround
drivers: add offline (O/H) port device support
Hemant Agrawal (11):
net/dpaa: fix double close and null deref on remove
net/dpaa: fix probe success when FMC init fails
net/dpaa: fix resource leak on probe failure
net/dpaa: fix free port resources on close
bus/dpaa: accept QDMA device name in devargs
net/dpaa: optimize FM deconfig
mempool/dpaa: fix write after free on pool free
net/dpaa: support Rx/Tx taildrop threshold devarg
net/dpaa: support non fmX-macY type of shared Ethernet name
bus/dpaa: improve log macro usages
doc: update release notes with NXP DPAA changes
Jun Yang (11):
bus/dpaa: refine fman naming
bus/dpaa: scan max BPID from DTS
drivers: shutdown DPAA FQ by fq descriptor
drivers: add DPAA cgrid cleanup support
bus/dpaa: improve FQ shutdown with channel validation
drivers: add BMI Tx statistics
net/dpaa: optimize FMC MAC type parsing
drivers: release DPAA bpid on driver destructor
net/dpaa: support fmcless rxq number as devargs
bus/dpaa: optimize DPAA multi-entry buffer pool operations
crypto/dpaa_sec: improve crypto fq resource handling
Prashant Gupta (2):
bus/dpaa: fix FQD dest wq channel decoding
drivers: add process-type guards for secondary process
Vanshika Shukla (1):
net/dpaa: enhance VSP port support
doc/api/doxy-api-index.md | 1 +
doc/guides/dmadevs/dpaa.rst | 30 +-
doc/guides/nics/dpaa.rst | 50 +-
doc/guides/rel_notes/release_26_11.rst | 31 +
drivers/bus/dpaa/base/fman/fman.c | 42 +-
drivers/bus/dpaa/base/fman/fman_hw.c | 202 +++--
drivers/bus/dpaa/base/fman/netcfg_layer.c | 8 +-
drivers/bus/dpaa/base/qbman/bman.c | 60 +-
drivers/bus/dpaa/base/qbman/bman_driver.c | 65 +-
drivers/bus/dpaa/base/qbman/qman.c | 175 +++--
drivers/bus/dpaa/base/qbman/qman.h | 23 +-
drivers/bus/dpaa/base/qbman/qman_driver.c | 29 +-
drivers/bus/dpaa/bus_dpaa_driver.h | 4 +-
drivers/bus/dpaa/dpaa_bus.c | 187 +++--
drivers/bus/dpaa/dpaa_bus_base_symbols.c | 4 +
drivers/bus/dpaa/include/fman.h | 36 +-
drivers/bus/dpaa/include/fsl_bman.h | 56 +-
drivers/bus/dpaa/include/fsl_qman.h | 50 +-
drivers/bus/dpaa/rte_dpaa_logs.h | 2 +
drivers/crypto/dpaa_sec/dpaa_sec.c | 147 +++-
drivers/dma/dpaa/dpaa_qdma.c | 120 ++-
drivers/mempool/dpaa/dpaa_mempool.c | 72 +-
drivers/mempool/dpaa/dpaa_mempool.h | 2 +-
drivers/net/dpaa/dpaa_ethdev.c | 507 +++++++++++--
drivers/net/dpaa/dpaa_ethdev.h | 25 +-
drivers/net/dpaa/dpaa_flow.c | 134 ++--
drivers/net/dpaa/dpaa_flow.h | 7 +-
drivers/net/dpaa/dpaa_fmc.c | 91 ++-
drivers/net/dpaa/dpaa_oldev.c | 875 ++++++++++++++++++++++
drivers/net/dpaa/meson.build | 11 +-
drivers/net/dpaa/rte_pmd_dpaa_oldev.h | 158 ++++
31 files changed, 2694 insertions(+), 510 deletions(-)
create mode 100644 drivers/net/dpaa/dpaa_oldev.c
create mode 100644 drivers/net/dpaa/rte_pmd_dpaa_oldev.h
--
2.25.1
