Currently, `iavf_dev_start()` clears `adapter->stopped` before several
operations that can fail. A subsequent `iavf_dev_stop()` then disables
interrupts and stops and resets queues even though startup did not
complete.
Mark the adapter running only after startup succeeds, and return early
from stop when it is already stopped.
Fixes: 69dd4c3d0898 ("net/avf: enable queue and device")
Cc: [email protected]
Signed-off-by: Anatoly Burakov <[email protected]>
---
drivers/net/intel/iavf/iavf_ethdev.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/intel/iavf/iavf_ethdev.c
b/drivers/net/intel/iavf/iavf_ethdev.c
index c0c58af746..8930ee8709 100644
--- a/drivers/net/intel/iavf/iavf_ethdev.c
+++ b/drivers/net/intel/iavf/iavf_ethdev.c
@@ -1047,7 +1047,6 @@ iavf_dev_start(struct rte_eth_dev *dev)
return -1;
wb_on_itr = (vf->vf_res->vf_cap_flags & VIRTCHNL_VF_OFFLOAD_WB_ON_ITR)
!= 0;
- adapter->stopped = 0;
vf->max_pkt_len = dev->data->mtu + IAVF_ETH_OVERHEAD;
vf->num_queue_pairs = RTE_MAX(dev->data->nb_rx_queues,
@@ -1120,6 +1119,7 @@ iavf_dev_start(struct rte_eth_dev *dev)
}
iavf_phc_sync_alarm_start(dev);
+ adapter->stopped = 0;
/* An explicit start supersedes any pending deferred start */
vf->start_pending = false;
@@ -1150,13 +1150,13 @@ iavf_dev_stop(struct rte_eth_dev *dev)
if (adapter->closed)
return -1;
+ if (adapter->stopped == 1)
+ return 0;
+
if (!(vf->vf_res->vf_cap_flags & VIRTCHNL_VF_OFFLOAD_WB_ON_ITR) &&
dev->data->dev_conf.intr_conf.rxq != 0)
rte_intr_disable(intr_handle);
- if (adapter->stopped == 1)
- return 0;
-
iavf_phc_sync_alarm_stop(dev);
/* Disable the interrupt for Rx */
--
2.52.0
