> -----Original Message----- > From: Stephen Hemminger <[email protected]> > Sent: Thursday, 15 October 2026 05:09 > To: Sriram Yagnaraman <[email protected]> > Cc: [email protected]; Jakub Grajciar <[email protected]>; [email protected] > Subject: Re: [PATCH 0/6] net/memif: lifecycle fixes and unit test > > On Wed, 14 Oct 2026 11:12:51 +0200 > Sriram Yagnaraman <[email protected]> wrote: > > > This series fixes a set of error-path and lifecycle bugs in the memif > > PMD and adds a unit test for the driver. > > > > The first five patches are fixes: > > > > - guard eth_memif_tx() against an empty burst so a zero-count call > > returns before touching the burst or the ring; > > - close file descriptor 0 instead of leaking it (the close path > > tested for fd > 0 instead of fd >= 0); > > - free the MAC address allocated during probe when a later step > > fails, instead of leaking it; > > - unwind a partially-created device on failure in memif_create(), > > releasing the port and the process-private data rather than > > returning with them registered and leaked; > > - disconnect the device on close so queues and shared regions are > > torn down, and make memif_disconnect() safe to call on a device > > that was configured but never started. > > > > The last patch adds a memif PMD unit test (app/test, > > memif_pmd_autotest) that stands up a server/client vdev pair over a > > loopback socket and covers dev_info, link state, stats, single- and > > multi-segment loopback, stop/start reconnect, empty Tx burst, and close > without stop. > > > > Verified: memif_pmd_autotest passes 9/9; check-git-log and checkpatch > > are clean across the series. > > > After walking through code when using bonding etc, sometimes apps send 0 > packets as keepalive time call. > > AI did find some other things to address.. > > Series applies cleanly to main (2a58f6e) and builds at every commit with - > Dwerror=true. Not run. No errors; warnings below, so no Reviewed-by yet. > >
Thanks a lot for the review, sent v2 now with fixes. v2 includes additional patches for "EAL-owned memseg file closing" and "bogus Tx count on invalid interrupt FD".
