On Wed, 14 Oct 2026 10:38:58 -0700 Stephen Hemminger <[email protected]> wrote: > On Wed, 14 Oct 2026 17:21:01 +0000 > Dawid Wesierski <[email protected]> wrote: > > > +RTE_EXPORT_EXPERIMENTAL_SYMBOL(rte_pcapng_tsc_to_ns, 26.11) > > +uint64_t > > +rte_pcapng_tsc_to_ns(const rte_pcapng_t *self, uint64_t tsc) > > +{ > > + return pcapng_timestamp(self, tsc); > > +} > > + > > Since the tsc_to_ns is independent of the pcapng handle, I had some > patches in other work which made it not require pcapng_open and/or move > it to EAL. What do you think?
Agreed. The conversion uses only the TSC and wall clock reference that rte_pcapng_fdopen() takes. Nothing else in the handle is necessary. A helper in EAL is better: other code can use it too, for example rpcapd, to stamp a packet with its capture time and not with the time of the burst. Our application does not need rte_pcapng_tsc_to_ns(). It gives the PTP time of the NIC to rte_pcapng_copy(). Thus I will send v8 without rte_pcapng_tsc_to_ns(), and the patch then does only the API change of rte_pcapng_copy(). Your helper can come in its own series, with its users. One point for your helper, and for any code that reads back the block from rte_pcapng_copy() before rte_pcapng_write_packets(): with this patch, the timestamp field holds the TSC with bit 63 set, or the caller time in nanoseconds with bit 63 clear. A question on the schedule. 26.11-rc1 is out, and this patch changes the API of rte_pcapng_copy(). v6 has the state Accepted in patchwork since June, but it is not in main. Can v8 go into 26.11? If it must wait for the next ABI version, please tell me. We will then keep it in our DPDK patch set until that release. v8 is tested with pcapng_autotest (also with ASan) on 26.11-rc1, and with dpdk-dumpcap on testpmd for the TSC path. Thanks, Dawid --------------------------------------------------------------------- Intel Technology Poland sp. z o.o. ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-316 | Kapital zakladowy 200.000 PLN. Spolka oswiadcza, ze posiada status duzego przedsiebiorcy w rozumieniu ustawy z dnia 8 marca 2013 r. o przeciwdzialaniu nadmiernym opoznieniom w transakcjach handlowych. Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiekolwiek przegladanie lub rozpowszechnianie jest zabronione. This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by others is strictly prohibited.
