On Wed, Oct 14, 2026 at 12:24:27PM +0000, Dawid Wesierski wrote: > From: Marek Kasiewicz <[email protected]> > > iavf_dev_close() unregisters iavf_dev_interrupt_handler() with > rte_intr_callback_unregister() and ignores the result. That call > returns -EAGAIN, and leaves the callback registered, while the > interrupt thread is running a callback of the same source. > > Close hits that window. It sends virtchnl commands (RSS, promiscuous > mode, flows), and iavf_dev_interrupt_handler() handles each response. > The handler clears the pending command before it returns, so the > thread waiting in iavf_wait_for_msg() can go on to the unregister > while the interrupt thread is still inside the callback. This is > likely when the two threads share a CPU. > > Two failures follow: > - The interrupt thread resumes the callback after > rte_eth_dev_release_port() has set dev->data to NULL, and > iavf_handle_virtchnl_msg() dereferences it: segmentation fault. > - The callback returns, but its source stays registered after the > port is closed. At rte_eal_cleanup(), > pci_vfio_unmap_resource_primary() closes the interrupt eventfd, and > the next rebuild of the epoll set aborts the process: > EAL: PANIC in eal_intr_thread_main(): > Error adding fd 49 epoll_ctl, Bad file descriptor > > Use rte_intr_callback_unregister_sync(), as ice_dev_close() does. The > iavf_dev_init() error path has the same pattern; fix it too. > > The sync variant waits for a running callback to return. It would > spin forever only if called from iavf_dev_interrupt_handler() itself, > and that handler never closes or re-initializes the port: it hands PF > events and resets to the iavf-event thread with iavf_dev_event_post(). > A close from any other interrupt thread callback, such as an alarm, > returns at once, because the iavf source is not active then. > > Fixes: 22b123a36d07 ("net/avf: initialize PMD") > Fixes: e35a5737a746 ("net/iavf: unregister interrupt handler before FD close") > Cc: [email protected] > > Signed-off-by: Marek Kasiewicz <[email protected]> > Signed-off-by: Dawid Wesierski <[email protected]> > --- > drivers/net/intel/iavf/iavf_ethdev.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > Acked-by: Bruce Richardson <[email protected]>
Patch applied to dpdk-next-net-intel. Thanks, /Bruce
