Hi Stephen,

We would appreciate feedback on the ethdev design, the experimental
PIO APIs, and PF/VF devargs.

Lots of feedback from AI review. Mostly it needs to be tested with testpmd

Thanks for the feedback. I am newbie to dpdk and will try to adapt with the process. We will address the AI review feedback and also we will plan to test our driver with testpmd before submitting the next patchset.

before review consideration. And you are too late for 26.11

We will resubmit for 27.03 after addressing all the review comments.


Review: [RFC 0/4] net/mcdma: add Altera MCDMA poll mode driver

Applied on 26.11-rc2, builds clean with -Dwerror at each commit.
Post-apply sources read, not just diffs.

Series-level
------------

Target release. 26.11 is at rc2; a new driver lands in 27.03.
RTE_EXPORT_EXPERIMENTAL_SYMBOL(..., 26.11) in patches 3/4 should say
27.03, and the series needs a release notes entry in the 27.03 file.

Sure.


PCI ID and PF/VF model (you asked about devargs). The ID table is
vendor 0x1172, device 0x0000, i.e. the Altera default IDs. Any
Altera design left at default IDs will probe as MCDMA. Whether a
function is PF or VF is decided by the presence of pf_index=, and a
VF needs parent_pf_idx= to find its channel count. The usual way to
do this in DPDK is distinct device IDs for PF and VF (and a real

Since ours is FPGA drivers this will be tricky as the IP configuration in a design may not always have the device IDs assigned and even though assigned every design can have a different device IDs which may be difficult to add in the enumeration list. This is why we have this approach to distinguish with devargs. Is there any other way we can approach this?

device ID for the MCDMA IP); then is_pf comes from the match entry
and both devargs go away. A VF probed with no devargs at all
currently fails (see patch 1).

As current enumeration is based on the devargs to decide on the pf/vf, the driver is designed to fail without this. Please guide how it can be done without this.

PMD-specific API (you asked about it). Patch 4 reimplements what
ethdev already has: eth_dev_ops.get_reg / rte_eth_dev_get_reg_info_ext()
gives named register dumps that testpmd and dpdk-proc-info already
consume. Implement .get_reg and drop rte_pmd_mcdma_qcsr_read/dump.

Thanks for pointing we will fix the driver to use this.

Patch 3 (PIO) has no generic equivalent, see notes there.

testpmd. mcdma.rst says the driver has not been tested with testpmd.
It should be before a non-RFC submission; it will exercise close,
stop, mtu set and secondary process paths that pktgen does not.

Sure, we will test the driver with testpmd.



Patch 1/4: net/mcdma: add Altera MCDMA poll mode driver skeleton
----------------------------------------------------------------


We are reviewing the AI review feedback and will get back with specific query and concern if any while addressing them.

Regards,
Subhransu

Reply via email to