On Tue, 17 Nov 2026 23:56:41 +0800
Jiacheng Ye <[email protected]> wrote:
> net/hinic3: add PMD features and fixes
>
> This series fixes offload capability advertisement, cmdq/compact CQE
> configuration, and a handful of driver defects, and adds NIC
> type identification, FEC, CIR drop statistics, VF LAG/link state, COS
> mask/map, mbox recording, RSS hash configuration, compact CQE Rx/Tx
> paths, TSO segment expansion, Tx burst mode reporting, queue statistics,
> pseudo-header checksum, per-tile cmdq ops, SP560 NIC support, and device
> kvargs tunables.
>
> Changes in v7:
Need to resolve the last warning.
Subject: Re: [PATCH v7 00/29] net/hinic3 series
All 29 patches apply to main and every commit builds with
-Dwerror=true. The open items from v6 are resolved: SP230 no longer
allocates eventfds or enables the Rx vectors when intr_conf.rxq is
off, dev_start honours admin_down, set_link_down restores admin_down
on failure, the Fixes: hashes are 12 characters, and rss_en now
tracks rss_type.
Two warnings remain, both about documentation rather than code.
Warning
=======
[PATCH 20/29] net/hinic3: refactor flow rule parsing
The patch drops every vlan_flag mask/value pair from the TCAM key,
e.g.:
- tcam_key->key_mask.vlan_flag = 1;
- tcam_key->key_info.vlan_flag = 0;
Before, FDIR rules matched only untagged packets. Now they match
tagged and untagged packets alike. That is a behaviour change, and
the commit message does not mention it. If it is intended, add a
sentence such as:
FDIR rules no longer match on the VLAN flag, so a rule now
hits both tagged and untagged packets.
If it is not intended, restore the vlan_flag lines.
[PATCH 22/29] net/hinic3: add device kvargs parameters support
[PATCH 23/29] net/hinic3: add compact CQE Rx path and ptype table
The new "Runtime Configuration" section uses a bullet list of
term/description pairs. Make it a definition list:
``tx_pending_limit`` (default ``2``)
Tx completion coalescing pending limit, in units of 8
packets.
``tx_coalescing_time`` (default ``2``)
Tx completion coalescing time, in microseconds.
``rx_cqe_compact_en`` (default ``1``)
Enable (``1``) or disable (``0``) compact CQE mode.
Ignored on NICs without compact CQE support.
``rx_cqe_coalesce_num`` (default ``7``)
Rx CQE coalescing count, in units of 8 packets.
``rx_cqe_timer_loop`` (default ``5``)
Rx CQE coalescing timer, in microseconds.
The rx_cqe_compact_en entry belongs in 23/29 and the rest in 22/29.
Info
====
[PATCH 06/29] rte_atomic_thread_fence() orders memory between CPUs,
not between the CPU and the device. If the cleared rq_ci has to be
ordered before the device runs again, use rte_io_wmb(). Otherwise
drop the fence.
[PATCH 07/29] dev_private is always present in a secondary process,
so this check is dead code, and the message and -ENOMEM do not match
what it tests:
if (nic_dev == NULL) {
PMD_DRV_LOG(ERR, "nic_dev hwdev is NULL, dev_name: %s",
Drop it.
[PATCH 10/29] This patch has Cc: stable, but it uses
HINIC3_IS_SP230_NIC() from 09/29, which is not tagged. Either tag
09/29 as well, or name the dependency so 25.11 backporters can find
it.
[PATCH 11/29] The explanation in the v6 reply checks out:
disable_all_msix() turns off every vector at hwif init, and
hinic3_dev_rx_queue_intr_enable() returns before
hinic3_set_msix_state(..., HINIC3_MSIX_ENABLE) on SP230 when
intr_conf.rxq is off. One gap remains. Nothing compares
nb_rx_queues + HINIC3_RX_VEC_START against hwif->attr.num_irqs, so
on a function with fewer vectors than queues, INTR names a vector
that does not exist. The intr_conf.rxq path has the same gap. Reject
that configuration in dev_configure, or skip the SP230 branch when
there are not enough vectors.
[PATCH 15/29] hinic3_dump_aeq_mbox_info() prints all
HINIC3_MBOX_SAVE_NUM slots even when fewer messages were recorded,
so empty slots appear as cmd 0, mod 0. Loop to save_mbox->count
instead.
[PATCH 17/29] hinic3_dev_set_link_up() clears admin_down before the
vport and port enable, but unlike set_link_down it does not restore
it on failure. If either call fails, admin_down stays cleared, and
the next PF link-up event enables the vport. Restore it on the error
paths, as set_link_down does.
[PATCH 25/29] The hinic3_copy_mempool_init() comment says the pool
"must be able to cover a full ring of in-flight packets", but the
pool is capped at 256 mbufs per queue. Reword the comment to say the
cap is deliberate, and that when the pool runs out the burst stops at
that packet.
[PATCH 26/29] Before this patch, every NIC got TCPUDP_CS set for
VXLAN, VXLAN-GPE and GENEVE packets:
SQ_CTRL_QUEUE_INFO_SET(queue_info->udp_dp_en, TCPUDP_CS) |
The new scalar path builds queue_info from TSO, PLDOFF, MSS and UC
only, so NICs without TX_WQE_COMPACT_TASK no longer set the bit. The
commit message does not mention this.
[PATCH 26/29, 28/29] The Tx path is selected by
NIC_F_TX_WQE_COMPACT_TASK and has no CQE, yet the function is named
hinic3_xmit_pkts_compact_cqe() and burst mode reports "compact CQE".
"compact task" would match what it does. In the scalar burst,
hinic3_get_sq_wqe() never returns NULL, so the !sq_wqe branch is dead
code.
Review-Result: WARNING