Hello Thomas, Neil, (will be back in a couple of days, thanks Thomas for pointing this thread)
On Thu, Jul 7, 2016 at 6:25 PM, Thomas Monjalon <thomas.monjalon at 6wind.com> wrote: > 2016-07-07 12:11, Neil Horman: >> On Thu, Jul 07, 2016 at 05:36:28PM +0200, Thomas Monjalon wrote: >> > Remove include of rte_pci.h in the generic header rte_dev.h >> > and move the macro DRIVER_REGISTER_PCI_TABLE in rte_pci.h. > [...] >> >> This seems strange to me, in that its odd for the driver information export >> macros to be spread out in multiple locations. Specifically it enjoins the >> use >> of the DRV_EXP_TAG macro, which helps centralize tag naming. Perhaps the >> happy >> medium is to place all the export macros (includnig PMD_REGISTER_DRIVER) into >> its own pmd_register.h header? > > I don't know. > David, your opinion? - The suggestion I did offline to Thomas was to move pci stuff in pci headers. We are trying to move from the "all pci" code in eal to accomodate for other "buses" / architectures. Having a pci macro in a generic header like rte_dev.h is wrong to me. Moving this to a new header like pmd_register.h sounds like a new generic header with pci specific stuff in it. So, I am not sure I follow you Neil. Can you elaborate ? - Why do you want to centralise the tag naming ? To avoid collisions ? Well, adding those tags should not happen that often and I think we can maintain this with careful reviews. -- David Marchand