On 6/14/2016 11:36 AM, Ferruh Yigit wrote:
> On 6/14/2016 7:59 AM, Beilei Xing wrote:
>> Update base driver for ixgbe, mainly work on new features and bug fixes.
>>
>> v2 changes:
>> Fix typos and update commit log.
>> Separate [patch 18/29] into two patches.
>>
> ...
>>
>> Acked-by: Helin Zhang <helin.zhang at intel.com>
>>
> Series Reviewed-by Ferruh Yigit <ferruh.yigit at intel.com>
>
Hi Beilei,
running check-git-log.sh scrip identified a few more issues in patch
subjects.
Can you please send a new version of patchset addressing following
issues, sorry for missing these at first review.
1) Unify "X550EM_A" usage in patch subject and commit messages.
ixgbe/base: fix firmware commands on x550em_a
ixgbe/base: add KR support for X550EM_A devices
"X550em_a" seems preferred in old commits.
2) Wrong headline lowercase:
ixgbe/base: allow setting mac anti spoofing per vf
ixgbe/base: add link mac setup for x550a SFP+
ixgbe/base: add mac link setup for x550a SFP
mac and vf should be upercase
3) Line too long:
Added support for the VLVF to be bypassed when adding/removing a
VFTA entry.
4) Wrong tag:
Fixes: 86b8fb293fdf ("ixgbe/base: add sw-firmware sync for
resource sharing)
missing a " at the end.
Regards,
ferruh
