Hi Jan, On 3/7/2016 8:05 PM, Jan Medala wrote:
--snip-- > diff --git a/drivers/net/ena/ena_ethdev.h b/drivers/net/ena/ena_ethdev.h > new file mode 100644 > index 0000000..7f069b9 > --- /dev/null > +++ b/drivers/net/ena/ena_ethdev.h > @@ -0,0 +1,154 @@ > +/*- > +* BSD LICENSE > +* > +* Copyright (c) 2015-2016 Amazon.com, Inc. or its affiliates. > +* All rights reserved. > +* > +* Redistribution and use in source and binary forms, with or without > +* modification, are permitted provided that the following conditions > +* are met: > +* > +* * Redistributions of source code must retain the above copyright > +* notice, this list of conditions and the following disclaimer. > +* * Redistributions in binary form must reproduce the above copyright > +* notice, this list of conditions and the following disclaimer in > +* the documentation and/or other materials provided with the > +* distribution. > +* * Neither the name of copyright holder nor the names of its > +* contributors may be used to endorse or promote products derived > +* from this software without specific prior written permission. > +* > +* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS > +* "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT > +* LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR > +* A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT > +* OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, > +* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT > +* LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, > +* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY > +* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT > +* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE > +* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > +*/ > + > +#ifndef _ENA_ETHDEV_H_ > +#define _ENA_ETHDEV_H_ > + > +#include <rte_pci.h> > + > +#pragma GCC diagnostic ignored "-Wcast-qual" Is this #pragma really needed here? My setup compiles fine without warnings, and I reckon it's better not have this line if it's not needed just in case we inadvertently introduce additional warnings in the future. ---snip-- The only other thing I'd note with the rest of the patch-set is the output from checkpatch, which Bruce has already mentioned. Regards, David.