Hi Reshma,
> -----Original Message-----
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Reshma Pattan
> Sent: Thursday, March 24, 2016 11:11 PM
> To: dev at dpdk.org; Ananyev, Konstantin
> Cc: Pattan, Reshma
> Subject: [dpdk-dev] [PATCH v2] examples/l3fwd: fix validation for queue id of
> config tuple
>
> Added validation for queue id of config parameter tuple.
>
> This validation enforces user to enter queue ids of a port
> from 0 and in sequence.
>
> This additional validation on queue ids avoids ixgbe crash caused by null
> rxq pointer access inside ixgbe_dev_rx_init.
>
> Reason for null rxq is, L3fwd application allocates memory only for queues
> passed by user.
> But rte_eth_dev_start tries to initialize rx queues in sequence from 0 to
> nb_rx_queues,
> which is not true and coredump while accessing the unallocated queue .
>
You forgot to include the Fixes line.
> Signed-off-by: Reshma Pattan <reshma.pattan at intel.com>
> ---
> v2:
[...]
> + if (lcore_params[i].port_id == port) {
> + if (lcore_params[i].queue_id == queue+1)
> + queue = lcore_params[i].queue_id;
> + else
> + rte_exit(EXIT_FAILURE, "queue ids of the port
> %d must be"
> + " in sequence and must start
> with 0",
You should include a return at the end of the sentence.
> + lcore_params[i].port_id);
> + }
> }
> return (uint8_t)(++queue);
> }
> --
> 2.5.0
