2016-03-30 09:36, Stephen Hemminger: > On Wed, 30 Mar 2016 10:06:36 -0400 > Aaron Conole <aconole at redhat.com> wrote: > > --- a/drivers/net/e1000/Makefile > > +++ b/drivers/net/e1000/Makefile > > @@ -54,6 +54,9 @@ else > > # > > CFLAGS_BASE_DRIVER = -Wno-uninitialized -Wno-unused-parameter > > CFLAGS_BASE_DRIVER += -Wno-unused-variable > > +ifeq ($(shell test $(GCC_VERSION) -ge 60 && echo 1), 1) > > +CFLAGS_BASE_DRIVER += -Wno-misleading-indentation > > +endif > > endif > > NAK, don't do it to the whole file. > Fix the code (best option) > or use a pragma for the small area which is broken for other reasons.
Stephen, your solutions do not work because Aaron has not been allowed to modify this file. As long as we are not allowed to modify the Intel base drivers, I don't see any problem to hide some warnings in them. The warnings could help us to clean the code or fix some bugs but we are not allowed to... It is the responsibility of the driver maintainer to keep this nasty code.
