Hi Ananda,
> -----Original Message----- > From: Ananda Sathyanarayana [mailto:ananda at versa-networks.com] > Sent: Wednesday, November 2, 2016 6:47 AM > To: Lu, Wenzhuo > Cc: dev at dpdk.org; Ananda Sathyanarayana > Subject: [PATCH] E1000: fix for forced speed/duplex config > > From the code, it looks like, hw->mac.autoneg, variable is used to switch > between calling either autoneg function or forcing speed/duplex function. But > this variable is not modified in eth_em_start/eth_igb_start routines (it is > always > set to 1) even while forcing the link speed. > > Following discussion thread has some more information on this > > http://dpdk.org/ml/archives/dev/2016-October/049272.html > > Signed-off-by: Ananda Sathyanarayana <ananda at versa-networks.com> Thanks for the patch. It looks fine to me. But as it's a fix, would you like to add a Fixes tag for it?