Hello Wei, On Wed, Nov 16, 2016 at 3:40 AM, Wei Dai <wei.dai at intel.com> wrote: > In function pci_mknod_uio_dev() in lib/librte_eal/eal/eal_pci_uio.c, > The return value of mknod() is ret, not f got by fopen(). > So the value of ret should be checked for mknod(). > > Fixes: 67c536bdad93 ("pci: move uio mapping in a dedicated file")
The commit you are pointing is just moving the code. I would incriminate f7f97c16048e ("pci: add option --create-uio-dev to run without hotplug") The rest looks good to me. -- David Marchand