2016-10-04 09:03, Sergio Gonzalez Monroy: > On 03/10/2016 21:46, Thomas Monjalon wrote: > > 2016-10-03 08:55, Jean Tourrilhes: > >> On Mon, Oct 03, 2016 at 02:25:40PM +0100, Sergio Gonzalez Monroy wrote: > >>> Hi Jean, > >>> > >>> There are some format issues with the patch: > >>> > >>> You can run scripts/check-git-log.sh to check them: > >>> Wrong headline format: > >>> eal: Fix misleading error messages, errno can't be trusted. > >>> Wrong headline uppercase: > >>> eal: Fix misleading error messages, errno can't be trusted. > >>> Missing 'Fixes' tag: > >>> eal: Fix misleading error messages, errno can't be trusted. > >>> > >>> The script's output highlights the different issues. > >> SOrry about that, I casually read the page on > >> http://dpdk.org/dev, but obviously I need to look at it again. > > No problem. This guide is more oriented towards regular contributors. > > You come with a bug and its fix, we can make some effort to format > > the patch :) > > > > The title could be "mem: fix hugepage mapping error messages" [...] > > Sergio, do you have more comments? > > Nop. > > > Should we wait another version or is it OK? > > Maybe you'd prefer to rework it yourself? > > AFAICS it really is just the commit message formatting, so maybe you can > fix that when applying it?
Yes but I've just noticed that the Signed-off-by line is missing. Please Jean, could you add this required line with your explanations, rebase on fresh head and resend please?