> -----Original Message----- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Zoltan Kiss > Sent: Thursday, July 21, 2016 1:11 AM > To: dev at dpdk.org > Cc: Matias Elo <matias.elo at nokia-bell-labs.com>; Gonzalez Monroy, Sergio > <sergio.gonzalez.monroy at intel.com>; Yigit, Ferruh <ferruh.yigit at > intel.com>; > damarion at cisco.com; thomas.monjalon at 6wind.com > Subject: [dpdk-dev] [PATCH v2] net/i40e: remove weak symbols > > Using weak symbols have a few issues with static linking: > > - normally the linker searches the .o files already linked, if your weak > one is there, it won't check if there is a strong version > - unless the symbol is directly referred, but it's not the right thing to > rely on > - or --whole-archive specified in the command line, which pulls in a lot > of unwanted stuff > - whole-archive also makes libtool dropping the library from the command > line, which is what should happen with dynamic linking, but not with > static (observed on Ubuntu 14.04). This is an important bug if you > build a static library depending on DPDK > > This patch merges the two version and make the behaviour rely on the > config. > > If we can agree in the concept, I can send a series to fix this for the > other weak functions. > > Signed-off-by: Zoltan Kiss <zoltan.kiss at schaman.hu> > ---
Looks good to remove weak symbols. Just one concern is vector PMD is one specific part to different Micro-Architecture. It's better to keep independent from normal tx/rx files. Think about ixgbe_rxtx_vec_neon.c and ixgbe_rxtx_vec_sse.c Thanks Jingjing
