On 12 October 2016 at 10:55, Zhang, Qi Z <qi.z.zhang at intel.com> wrote: > Hi Jianbo > >> -----Original Message----- >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Jianbo Liu >> Sent: Wednesday, August 24, 2016 5:54 PM >> To: Zhang, Helin <helin.zhang at intel.com>; Wu, Jingjing >> <jingjing.wu at intel.com>; jerin.jacob at caviumnetworks.com; dev at >> dpdk.org >> Cc: Jianbo Liu <jianbo.liu at linaro.org> >> Subject: [dpdk-dev] [PATCH 1/5] i40e: extract non-x86 specific code from >> vector >> driver >> >> move scalar code which does not use x86 intrinsic functions to new file >> "i40e_rxtx_vec_common.h", while keeping x86 code in i40e_rxtx_vec.c. >> This allows the scalar code to to be shared among vector drivers for >> different >> platforms. >> >> Signed-off-by: Jianbo Liu <jianbo.liu at linaro.org> >> --- ... > > Should we rename the function "_40e_rx_queue_release_mbufs_vec" to > "i40e_rx_queue_release_mbufs_vec_default", so functions be wrapped can follow > a consistent rule?
I think these two ways are different. For func/_func, _func implements what func needs to do, they are same. We needs _func inline, to be called in different ARCHs. But for func/func_default, func_default is the default behavior, but you can use or not-use it in func.
