Hi,
> -----Original Message-----
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Masoud
> Hasanifard
> Sent: Saturday, September 17, 2016 2:43 AM
> To: dev at dpdk.org
> Cc: Masoud Hasanifard
> Subject: [dpdk-dev] [PATCH] hash: Correctly set the compare function.
Commit titles start with lowercase ("correctly") and without a dot at the end.
>
> Set cmp_jump_table_idx to KEY_CUSTOM in rte_hash_cmp_eq so that the
> custom
> function we are setting in rte_hash_set_cmp_func properly works. The
> custom
> function is only called by rte_hash_cmp_eq if cmp_jump_table_idx is set to
> KEY_CUSTOM.
I think this is a fix, so probably it should contain the following "Fixes" line
in the commit message:
Fixes: 95da2f8e9c61 ("hash: customize compare function")
> ---
> lib/librte_hash/rte_cuckoo_hash.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/lib/librte_hash/rte_cuckoo_hash.c
> b/lib/librte_hash/rte_cuckoo_hash.c
> index 26e54f6..2e6429f 100644
> --- a/lib/librte_hash/rte_cuckoo_hash.c
> +++ b/lib/librte_hash/rte_cuckoo_hash.c
> @@ -98,6 +98,7 @@ rte_hash_find_existing(const char *name)
>
> void rte_hash_set_cmp_func(struct rte_hash *h, rte_hash_cmp_eq_t
> func)
> {
> + h->cmp_jump_table_idx = KEY_CUSTOM;
> h->rte_hash_custom_cmp_eq = func;
> }
>
> --
> 2.7.4
Good catch! Two comments inline.
Could you send a v2 with those two things added?
Thanks for the patch,
Pablo
