Hi, yuanhan: > -----Original Message----- > From: Yuanhan Liu [mailto:yuanhan.liu at linux.intel.com] > Sent: Tuesday, September 20, 2016 7:50 PM > To: Yang, Zhiyong <zhiyong.yang at intel.com> > Cc: dev at dpdk.org; thomas.monjalon at 6wind.com; pmatilai at redhat.com; > Van Haaren, Harry <harry.van.haaren at intel.com> > Subject: Re: [PATCH v3 2/2] net/vhost: add pmd xstats > > On Tue, Sep 20, 2016 at 05:36:45PM +0800, Zhiyong Yang wrote: > > +enum vhost_xstats_pkts { > > + VHOST_UNDERSIZE_PKT = 0, > > + VHOST_64_PKT, > > + VHOST_65_TO_127_PKT, > > + VHOST_128_TO_255_PKT, > > + VHOST_256_TO_511_PKT, > > + VHOST_512_TO_1023_PKT, > > + VHOST_1024_TO_1522_PKT, > > + VHOST_1523_TO_MAX_PKT, > > + VHOST_BROADCAST_PKT, > > + VHOST_MULTICAST_PKT, > > Another thing I noted is that you dropped unitcast counting here. I think the > comment I gave in last email was you don't have to update it every time we > rx/tx packets, instead, you could calcuate it on query (at > vhost_dev_xstats_get). I was not asking you to drop it. >
Ok, I'm sorry to misunderstand you and will restore it in next V4 patch as you suggest. > --yliu