On Wed, Dec 14, 2016 at 05:06:23PM +0000, Ferruh Yigit wrote: > Hi Michal, > > On 12/13/2016 1:08 AM, Michał Mirosław wrote: > > Signed-off-by: Michał Mirosław <michal.miros...@atendesoftware.pl> > > --- > > lib/librte_eal/linuxapp/kni/kni_misc.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/lib/librte_eal/linuxapp/kni/kni_misc.c > > b/lib/librte_eal/linuxapp/kni/kni_misc.c > > index 497db9b..f0247aa 100644 > > --- a/lib/librte_eal/linuxapp/kni/kni_misc.c > > +++ b/lib/librte_eal/linuxapp/kni/kni_misc.c > > @@ -363,8 +363,8 @@ kni_ioctl_create(struct net *net, uint32_t ioctl_num, > > up_read(&knet->kni_list_lock); > > > > net_dev = alloc_netdev(sizeof(struct kni_dev), dev_info.name, > > -#ifdef NET_NAME_UNKNOWN > > - NET_NAME_UNKNOWN, > > +#ifdef NET_NAME_USER > > + NET_NAME_USER, > > Probably NET_NAME_USER fits better to definition. > But functionally, I wonder if you have a use case to use > "name_assign_type" ?
I just read what NET_NAME_UNKNOWN/NET_NAME_USER is supposed to do. UNKNOWN is for "old" drivers that don't know the source of the name. USER is for a name, that comes from a user and as such is not to be renamed by udev. Best Regards, Michał Mirosław
