Hi, Yigit > -----Original Message----- > From: Yigit, Ferruh > Sent: Wednesday, December 21, 2016 1:01 AM > To: Zhao1, Wei <[email protected]>; [email protected] > Cc: Lu, Wenzhuo <[email protected]> > Subject: Re: [dpdk-dev] [PATCH 15/18] net/ixgbe: parse flow director filter > > On 12/2/2016 10:43 AM, Wei Zhao wrote: > > From: wei zhao1 <[email protected]> > > > > check if the rule is a flow director rule, and get the flow director info. > > > > Signed-off-by: wei zhao1 <[email protected]> > > Signed-off-by: Wenzhuo Lu <[email protected]> > > --- > > <...> > > > + PATTERN_SKIP_VOID(rule, struct ixgbe_fdir_rule, > > + RTE_FLOW_ERROR_TYPE_ITEM_NUM); > > + if (item->type != RTE_FLOW_ITEM_TYPE_ETH && > > + item->type != RTE_FLOW_ITEM_TYPE_IPV4 && > > + item->type != RTE_FLOW_ITEM_TYPE_IPV6 && > > + item->type != RTE_FLOW_ITEM_TYPE_UDP && > > + item->type != RTE_FLOW_ITEM_TYPE_VXLAN && > > + item->type != RTE_FLOW_ITEM_TYPE_NVGRE) { > > This gives build error [1], there are a few more same usage: > > .../drivers/net/ixgbe/ixgbe_ethdev.c:9238:17: error: comparison of constant > 241 with expression of type 'const enum rte_flow_item_type' is always true > [-Werror,-Wtautological-constant-out-of-range-compare] > item->type != RTE_FLOW_ITEM_TYPE_NVGRE) { > > >
Ok, I will add two type definition RTE_FLOW_ITEM_TYPE_NVGRE and RTE_FLOW_ITEM_TYPE_E_TAG into const enum rte_flow_item_type to eliminate this problem. Thank you.
