2016-12-20 13:36, Ferruh Yigit: > On 12/13/2016 5:41 PM, Tomasz Kulasek wrote: > > From: "Ananyev, Konstantin" <konstantin.anan...@intel.com> > > > > Signed-off-by: Konstantin Ananyev <konstantin.anan...@intel.com> > > --- > > <...> > > > > > uint16_t > > +vmxnet3_prep_pkts(__rte_unused void *tx_queue, struct rte_mbuf **tx_pkts, > > + uint16_t nb_pkts) > > +{ > <...> > > + > > +#ifdef RTE_LIBRTE_ETHDEV_DEBUG > > + ret = rte_validate_tx_offload(m); > > + if (ret != 0) { > > + rte_errno = ret; > > + return i; > > + } > > +#endif > > + ret = rte_net_intel_cksum_prepare(m); > > Since this API used beyond Intel drivers, what do you think renaming it? > rte_net_generic_cksum_prepare() ?
I think it is good to have Intel in its name because it is where it comes from. Hopefully we won't have to care about this specific API when tx_prepare will be well accepted.