Hi Ferruh,
On Thu, Feb 02, 2017 at 03:34:04PM +0000, Ferruh Yigit wrote:
> On 2/2/2017 10:34 AM, Nelio Laranjeiro wrote:
> > First two bytes of the Ethernet header was written twice at the same place.
>
> Is this patch just prevents re-writing 2 bytes of buffer, or changes the
> buffer content as well?
It only prevents to re-write 2 bytes of the buffer.
> If buffer content also updated, I think it would be nice to mention in
> the commit log.
The buffer is only read.
> And if buffer content is not changed, will it be fair to say this patch
> is refactor patch instead of fix?
Well, I understand that it can be seen as not being a fix as the final
behavior remains the same. Is it possible to change it to:
"net/mlx5: avoid re-writing first 2 bytes of Ethernet header"
> > Fixes: b8fe952ec5b6 ("net/mlx5: prepare Tx vectorization")
> >
> > Signed-off-by: Yongseok Koh <[email protected]>
> > Signed-off-by: Nelio Laranjeiro <[email protected]>
> > ---
> <...>
Regards,
--
Nélio Laranjeiro
6WIND
