Hi Akhil, > -----Original Message----- > From: [email protected] [mailto:[email protected]] > Sent: Monday, April 03, 2017 11:53 AM > To: [email protected] > Cc: Doherty, Declan; De Lara Guarch, Pablo; Akhil Goyal > Subject: [PATCH] test/test: improve dequeue logic for crypto operation > > From: Akhil Goyal <[email protected]> > > While enqueue/dequeue operations in test_perf_aes_sha, > the underlying implementation may not be able to dequeue > the same number of buffers as enqueued. So, it may be > necessary to perform more dequeue operations if the gap > is more than pparams->burst_size * NUM_MBUF_SETS. > > Other algos may also need to update the logic if required. >
In which way this patch improves the dequeue logic? Is it improving the performance somehow? From what I see, it is unlikely that you are going to experience the problem, as the internal ring is PERF_NUM_OPS_INFLIGHT, which is 128, higher than pparams->burst_size * NUM_MBUF_SETS, which is 256. And even if you do meet that problem, then you would be reusing mbufs, but that is OK as we are not verifying the output. Thanks, Pablo
