Some ethdev devices like nicvf thunderx PMD need special treatment for Secondary queue set(SQS) PCIe VF devices, where, it expects to not unmap or free the memory without registering the ethdev subsystem.
Introducing a new RTE_PCI_DRV_KEEP_MAPPED_RES PCI driver flag to request PCI subsystem to not unmap the mapped PCI resources(PCI BAR address) if unsupported device detected. Suggested-by: Ferruh Yigit <ferruh.yi...@intel.com> Signed-off-by: Jerin Jacob <jerin.ja...@caviumnetworks.com> --- v3: Remove the use of RTE_PCI_DRV_KEEP_MAPPED_RES in detach()(Ferruh) http://dpdk.org/ml/archives/dev/2017-June/067691.html v2: Introduced RTE_PCI_DRV_KEEP_MAPPED_RES flag scheme(Ferruh), Based on the discussion in the following thread. http://dpdk.org/ml/archives/dev/2017-June/067091.html --- lib/librte_eal/common/eal_common_pci.c | 7 ++++++- lib/librte_eal/common/include/rte_pci.h | 2 ++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/lib/librte_eal/common/eal_common_pci.c b/lib/librte_eal/common/eal_common_pci.c index 5ae520186..78b097e61 100644 --- a/lib/librte_eal/common/eal_common_pci.c +++ b/lib/librte_eal/common/eal_common_pci.c @@ -221,7 +221,12 @@ rte_pci_probe_one_driver(struct rte_pci_driver *dr, ret = dr->probe(dr, dev); if (ret) { dev->driver = NULL; - if (dr->drv_flags & RTE_PCI_DRV_NEED_MAPPING) + if ((dr->drv_flags & RTE_PCI_DRV_NEED_MAPPING) && + /* Don't unmap if device is unsupported and + * driver needs mapped resources. + */ + !(ret > 0 && + (dr->drv_flags & RTE_PCI_DRV_KEEP_MAPPED_RES))) rte_pci_unmap_device(dev); } diff --git a/lib/librte_eal/common/include/rte_pci.h b/lib/librte_eal/common/include/rte_pci.h index b82ab9e79..0284a6208 100644 --- a/lib/librte_eal/common/include/rte_pci.h +++ b/lib/librte_eal/common/include/rte_pci.h @@ -212,6 +212,8 @@ struct rte_pci_bus { #define RTE_PCI_DRV_INTR_LSC 0x0008 /** Device driver supports device removal interrupt */ #define RTE_PCI_DRV_INTR_RMV 0x0010 +/** Device driver needs to keep mapped resources if unsupported dev detected */ +#define RTE_PCI_DRV_KEEP_MAPPED_RES 0x0020 /** * A structure describing a PCI mapping. -- 2.13.1
